Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1.75-compatible lockfiles when running Minimal CI #450

Closed
wants to merge 4 commits into from

Conversation

mxgrey
Copy link
Collaborator

@mxgrey mxgrey commented Dec 18, 2024

This is an implementation of the suggestion that I made here that aims to keep the Minimal CI stable even as new versions of dependencies (including transitive dependencies) are released.

The lockfiles are admittedly somewhat annoyingly bulky, especially since each example crate needs one. We should be able to reduce that to a single lockfile if we double this up with the suggestion here to put a workspace at the root of the repo.

I understand that this PR may be controversial, so I'm opening it to test whether it even works and then facilitate discussion about whether or not this is how we'd like to resolve #449, or whether we should consider another approach.

@mxgrey
Copy link
Collaborator Author

mxgrey commented Dec 18, 2024

It seems like colcon-cargo might be ignoring the lockfiles that are present inside of each crate directory, although it's hard to tell for sure since the workflow terminal output gives pretty limited information.

In any case the lockfile approach doesn't seem to be working so I'll try a different approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust Minimal Workflow Failing
1 participant