Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rqt_dotgraph: 0.0.4-1 in 'rolling/distribution.yaml' [bloom] #43026

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

xydesa
Copy link
Contributor

@xydesa xydesa commented Oct 2, 2024

Increasing version of package(s) in repository rqt_dotgraph to 0.0.4-1:

rqt_dotgraph

* Contributors: Alexander Xydes, Thomas Denewiler

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Oct 2, 2024
Copy link
Collaborator

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first things first.
The license should be one of the open-source ones listed in https://opensource.org/licenses (preferably one of the "Popular licenses").
Although, the Creative Commons Zero v1.0 Universal license under which the rqt_dotgraph was released is not on the list.

However, the rqt_dotgraph sources are already in the index. This PR is only for adding binaries.

cc: @clalancette, @cottsay I would appreciate a second opinion on this PR.

@xydesa
Copy link
Contributor Author

xydesa commented Oct 3, 2024

@MichaelOrlov here's the previous conversation about the license for this package: #40169 (comment)

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine; we've already accepted the package with the license, the adding of the release section here is fine.

@clalancette clalancette merged commit 39217e0 into ros:master Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants