soem: 1.4.1001-1 in 'noetic/distribution.yaml' [bloom]

[mgruhler]

Increasing version of package(s) in repository soem to 1.4.1001-1:

• upstream repository: https://github.com/mgruhler/soem.git
• release repository: https://github.com/mgruhler/soem-gbp.git
• distro file: noetic/distribution.yaml
• bloom version: 0.9.7
• previous version for package: null

soem

* remove package upgrade message
* Contributors: D2/EIN-gr Gruhler, Matthias

[mgruhler]

thanks @sloretz for the merge.

The build, however, fails due to a warning which is being treated as an error. I cannot reproduce this locally with whatever flags I set, using standard Ubuntu Focal.

I also cannot reproduce with a prerelase check, as this fails with the following output

CMake Error at /usr/share/cmake-3.16/Modules/CMakeTestCCompiler.cmake:60 (message):
  The C compiler

    "/usr/lib/ccache/cc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /tmp/ws/build_isolated/soem/CMakeFiles/CMakeTmp
    
    Run Build Command(s):/usr/bin/make cmTC_a1177/fast && /usr/bin/make -f CMakeFiles/cmTC_a1177.dir/build.make CMakeFiles/cmTC_a1177.dir/build
    make[1]: Entering directory '/tmp/ws/build_isolated/soem/CMakeFiles/CMakeTmp'
    Building C object CMakeFiles/cmTC_a1177.dir/testCCompiler.c.o
    /usr/lib/ccache/cc    -o CMakeFiles/cmTC_a1177.dir/testCCompiler.c.o   -c /tmp/ws/build_isolated/soem/CMakeFiles/CMakeTmp/testCCompiler.c
    ccache: error: Failed to create directory /home/buildfarm/.ccache/tmp: Permission denied

I used this command generated via prerelease.ros.org:

mkdir -p /tmp/prerelease_job
cd /tmp/prerelease_job
generate_prerelease_script.py \
  https://raw.githubusercontent.com/ros-infrastructure/ros_buildfarm_config/production/index.yaml \
  noetic default ubuntu focal amd64 \
  soem \
  --level 1 \
  --output-dir ./

The build hasn't failed so far for kinetic and melodic. So it seams to be related to a new version of gcc (or soemthing) shipped with focal.

As this package only wraps an upstream package, where I'd like to only include releases of upstream, I'm hesitant to fix that error in the src. Can this be ignored somehow?

Any ideas what goes wrong or what I have to do to fix this? Thanks.

[sloretz]

@mgruhler It looks like -Werror is in SOEM/CMakeLists.txt

Here's the first mention of -WError in the log

cd /tmp/binarydeb/ros-noetic-soem-1.4.1001/obj-x86_64-linux-gnu/SOEM && /usr/lib/ccache/cc -DROS_BUILD_SHARED_LIBS=1 -I/tmp/binarydeb/ros-noetic-soem-1.4.1001/SOEM/soem -I/tmp/binarydeb/ros-noetic-soem-1.4.1001/SOEM/osal -I/tmp/binarydeb/ros-noetic-soem-1.4.1001/SOEM/osal/linux -I/tmp/binarydeb/ros-noetic-soem-1.4.1001/SOEM/oshw/linux  -g -O2 -fdebug-prefix-map=/tmp/binarydeb/ros-noetic-soem-1.4.1001=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Werror   -fPIC -o CMakeFiles/soem.dir/soem/ethercatbase.c.o   -c /tmp/binarydeb/ros-noetic-soem-1.4.1001/SOEM/soem/ethercatbase.c

I checked out the branch the Focal source package was built from in the release repo

$ git clone [email protected]:mgruhler/soem-gbp.git -b debian/ros-noetic-soem_1.4.1001-1_focal

and searched there for -Werror

$ grep . -R -e "Werror"
./SOEM/CMakeLists.txt:  set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Werror")
./SOEM/CMakeLists.txt:  set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Werror")
./SOEM/CMakeLists.txt:  set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Werror")
./SOEM/cmake/Modules/Platform/rt-kernel-gcc.cmake:set(CFLAGS "${CFLAGS} -Wall -Wextra -Wno-unused-parameter -Werror")

[mgruhler]

Thanks @sloretz . Silly me :-S Totally missed that.

I don't get why this warning is only triggered in a release build though. but nevermind. I just released a new version (see #25585) that should now (hopefully) build. (Prereleases still don't work for noetic or melodic...)

[sloretz]

Prereleases still don't work for noetic or melodic...

You mean, http://prerelease.ros.org/ doesn't work? Weird; it works for me. Mind opening an issue with more info? https://github.com/ros-infrastructure/prerelease_website/issues

[mgruhler]

The issue is not the website, but rather that running the prerelease (for noetic and melodic) fails. See ros-infrastructure/prerelease_website#63