Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport to Humble: Fix wShadow compile warning (#250) #266

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Backport to Humble: Fix wShadow compile warning (#250) #266

merged 1 commit into from
Dec 13, 2024

Conversation

Wiktor-99
Copy link

As Humble is LTS I think it would be nice to backport this fix.

@Wiktor-99
Copy link
Author

Hi @clalancette,
Since you were involved in the original PR#250, could you take a look at this?

@clalancette
Copy link
Contributor

clalancette commented Dec 12, 2024 •
edited
Loading

Pulls: #266
Gist: https://gist.githubusercontent.com/clalancette/3ead44a152eaa2750c16d94ccba37151/raw/dee6f70f535aee32f22385c125cd14c04879a83e/ros2.repos
BUILD args: --packages-above-and-dependencies pluginlib
TEST args: --packages-above pluginlib
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14949

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette merged commit 5b52801 into ros:humble Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wiktor-99 @clalancette @SteveMacenski