Expose on-demand library load/unload in class loader constructor. #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nuclearsandwich kind ping |
|
Thank you for the PR! Unfortunately I don't think we should merge this one. It changes ABI, and ABI breaks cannot be accepted into released ROS distros. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on-demand library loading/unloading is hard-coded to
false. This leads to the fact that libraries are unloaded on destruction of theClassLoaderinstance, which can throw exceptions (see #234).In my use case I'd like to unload the libraries on-demand, so I do not have to deal with exceptions when the destructor of the
ClassLoaderinstance is called.This PR exposes the setting in the
ClassLoaderconstructor. The default value isfalsefor backwards compatibility.