-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use image_transport and cv_bridge targets #62
Conversation
Signed-off-by: Shane Loretz <[email protected]>
Rolling PR job failed because it used |
I approved but maybe the checks should be rerun? |
Signed-off-by: Shane Loretz <[email protected]>
Yeah, I'm not totally sure how to test this. The rolling jobs don't seem to have built the latest versions of it's dependencies yet. I pushed another commit since I think it will have the same issue with cv_bridge when vision_opencv gets a release. I'll try a local build and report back. |
With the latest version of vision_opencv and this PR this package builds successfully. I tested that I can load the plugin in rqt and visualize an image using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
This is a tradeoff we pay since PR jobs run based on the |
Fixes #61
⚠️ This needs to be targeted at a ROS Rolling specific branch.Done