Add Windows Compatibility Fixes for vision_opencv Build #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding code based on ros-perception#401
ijnek
requested changes
Nov 16, 2024
| @@ -90,3 +92,7 @@ install(TARGETS ${PROJECT_NAME} | |||
| ament_package( | |||
| CONFIG_EXTRAS "cmake/cv_bridge-extras.cmake.in" | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Please move this to line 41 in src/CMakeLists.txt.
There was a problem hiding this comment.
In my tests I can only move after line 64. That works?
| @@ -12,6 +12,8 @@ if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang") | |||
| add_compile_options(-Wall -Wextra) | |||
| endif() | |||
|
|
|||
| add_compile_options(-DHAVE_SNPRINTF) | |||
There was a problem hiding this comment.
I believe this is to treat the following warning:
warning C4996: '_vsnprintf': This function or variable may be unsafe. Consider using _vsnprintf_s instead.
Could you please replace the vnsprintf calls with vsnprintf_s instead of adding this compile option?
There was a problem hiding this comment.
The error that I trying to solve was that:
C:/boost/boost/assert/source_location.hpp(95,9): error C2039: '_snprintf': is not a member of 'std' (compiling source file <ANONYMIZED_PATH>/src/vision_opencv/cv_bridge/src/module_opencv3.cpp) [<ANONYMIZED_PATH>/build/cv_bridge/src/cv_bridge_boost.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\string(24): message: see declaration of 'std' (compiling source file <ANONYMIZED_PATH>/src/vision_opencv/cv_bridge/src/module_opencv3.cpp) [<ANONYMIZED_PATH>/build/cv_bridge/src/cv_bridge_boost.vcxproj]
C:/boost/boost/assert/source_location.hpp(95,9): error C2039: '_snprintf': is not a member of 'std' (compiling source file <ANONYMIZED_PATH>/src/vision_opencv/cv_bridge/src/module.cpp) [<ANONYMIZED_PATH>/build/cv_bridge/src/cv_bridge_boost.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\string(24): message: see declaration of 'std' (compiling source file <ANONYMIZED_PATH>/src/vision_opencv/cv_bridge/src/module.cpp) [<ANONYMIZED_PATH>/build/cv_bridge/src/cv_bridge_boost.vcxproj]
C:/boost/boost/assert/source_location.hpp(102,13): error C2039: '_snprintf': is not a member of 'std' (compiling source file <ANONYMIZED_PATH>/src/vision_opencv/cv_bridge/src/module_opencv3.cpp) [<ANONYMIZED_PATH>/build/cv_bridge/src/cv_bridge_boost.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\string(24): message: see declaration of 'std' (compiling source file <ANONYMIZED_PATH>/src/vision_opencv/cv_bridge/src/module_opencv3.cpp) [<ANONYMIZED_PATH>/build/cv_bridge/src/cv_bridge_boost.vcxproj]
C:/boost/boost/assert/source_location.hpp(102,13): error C2039: '_snprintf': is not a member of 'std' (compiling source file <ANONYMIZED_PATH>/src/vision_opencv/cv_bridge/src/module.cpp) [<ANONYMIZED_PATH>/build/cv_bridge/src/cv_bridge_boost.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\string(24): message: see declaration of 'std' (compiling source file <ANONYMIZED_PATH>/src/vision_opencv/cv_bridge/src/module.cpp) [<ANONYMIZED_PATH>/build/cv_bridge/src/cv_bridge_boost.vcxproj]
I can only solve this using -DHAVE_SNPRINTF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds compatibility improvements to enable successful building of
vision_opencvon Windows by introducing additional compiler options.Changes Made
Added Compiler Definitions for Windows Compatibility:
-DHAVE_SNPRINTFtoadd_compile_optionsto ensure that thesnprintffunction is available during compilation. This is a common requirement when building cross-platform code on Windows.Boost Python Library Static Linking on Windows:
target_compile_definitionswas updated with-DBOOST_PYTHON_STATIC_LIB. This option helps to statically link the Boost Python library, which is necessary for compatibility on Windows.Rationale
These changes are specifically intended as a workaround to address issues encountered when building
vision_opencvon Windows. By adding thesnprintfdefinition and setting Boost Python for static linking, this PR aims to resolve common build issues related to cross-platform support.Additional Notes
Resolves: #401