Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ZSTD plugin #12

Merged
merged 10 commits into from
Aug 28, 2023
Merged

Added ZSTD plugin #12

merged 10 commits into from
Aug 28, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Aug 21, 2023

Added ZSTD plugin

@ahcorde
Added ZSTD plugin
65be04f 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Aug 21, 2023
@ahcorde
make linters happy
80b607b 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
make linters happy
a3729ec 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Merge pull request #1 from ros-perception/ros2
21ea68d 
Port point_cloud_transport_plugins to ROS2
@ahcorde
Added to README.md
062b82e 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde marked this pull request as ready for review August 25, 2023 15:26
john-maidbot
john-maidbot requested changes Aug 26, 2023
View reviewed changes
Copy link
Collaborator

@john-maidbot john-maidbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding another plugin! 🚀 I have some minor comments I would like your feedback on before approving. If you think the change i suggested isnt needed though, just lmk 🙂

README.md Show resolved Hide resolved
zstd_point_cloud_transport/package.xml Outdated Show resolved Hide resolved
zstd_point_cloud_transport/package.xml Outdated Show resolved Hide resolved
zstd_point_cloud_transport/src/zstd_publisher.cpp Outdated Show resolved Hide resolved
zstd_point_cloud_transport/src/zstd_subscriber.cpp Outdated Show resolved Hide resolved
@ahcorde
Update author
95bf26f 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
john-maidbot
john-maidbot approved these changes Aug 27, 2023
View reviewed changes
Copy link
Collaborator

@john-maidbot john-maidbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for addressing my comments 👍

@ahcorde ahcorde merged commit 8fdc6d5 into ros2 Aug 28, 2023
3 checks passed
@ahcorde ahcorde deleted the ahcorde/zstd_plugin branch August 28, 2023 07:16
ahcorde added a commit that referenced this pull request Aug 28, 2023
@ahcorde
Added ZSTD plugin (#12) (#16)
156b65e 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-maidbot john-maidbot john-maidbot approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @john-maidbot