Feat/Add LifecycleNode Support #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsayedelsheikh
force-pushed
the
feature/support_life_cycle_node
branch
from
16c8087 to
7cbb9d3
Compare
ahcorde
requested changes
Feb 14, 2025
| @@ -0,0 +1,74 @@ | |||
| // Copyright (c) 2009, Willow Garage, Inc. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright (c) 2009, Willow Garage, Inc. | |
| // Copyright (c) 2025, Open Source Robotics Foundation, Inc. |
| @@ -73,33 +77,33 @@ class Publisher | |||
|
|
|||
| //! Publish a point cloud on the topics associated with this Publisher. | |||
| POINT_CLOUD_TRANSPORT_PUBLIC | |||
| void publish(const sensor_msgs::msg::PointCloud2 & message) const; | |||
There was a problem hiding this comment.
changes below are not required.
| @@ -67,7 +68,7 @@ class PublisherPlugin | |||
| //! \brief Advertise a topic, simple version. | |||
| POINT_CLOUD_TRANSPORT_PUBLIC | |||
| void advertise( | |||
| std::shared_ptr<rclcpp::Node> node, | |||
| NodeInterfaces::SharedPtr node_interfaces, | |||
There was a problem hiding this comment.
we should deprecate the old methods, we apply tic-toc, we deprecate the method in the release and we will remove them in the next one.
Same below
| @@ -69,7 +69,7 @@ namespace point_cloud_transport | |||
| /// | |||
| /// \tparam M Type of the published messages. | |||
| /// | |||
| template<class M> | |||
| template <class M> | |||
There was a problem hiding this comment.
restore style modfications
elsayedelsheikh
commented
Feb 14, 2025
| impl_->base_topic_ = point_cloud_topic; | ||
| impl_->loader_ = loader; | ||
|
|
||
| auto ns_len = node->get_effective_namespace().length(); | ||
| // FIXME: rclcpp::node_interfaces::NodeBaseInterface neither have get_effective_namespace() nor get_sub_namespace() |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes (#107)
In progress ...