Refactor PCLNode with Variadic Templates #511
Open
+1,670
−2,161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to centralize the ROS-related interfaces in the
PCLNodeclass.Previously, operations like subscribing, publishing with message filters, transforming clouds, and so on, were centralized in the
Filterclass.However, to extend this package with the development of new nodes (e.g.
SACSegmentation), requires the duplication of some boilerplate code, as evident in #510.This PR allows contributors to create new
pcl_ros nodesas simple asHappy to get your feedback and eventually improve / adapt the code