Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 port perception_pcl #229

Closed
wants to merge 21 commits into from

Conversation

klintan
Copy link
Contributor

@klintan klintan commented Apr 20, 2019

WIP

Wanted to keep it transparent so will start a draft PR. Doing the velodyne package which depends on this one.

Still not compiling, and will probably be working with a bit smaller feature-set before it's fully featured and working.

@SteveMacenski
Copy link
Member

@klintan is this draft required with your other PR?

@klintan
Copy link
Contributor Author

klintan commented Oct 16, 2019

@klintan is this draft required with your other PR?

No it is not related. This is including pcl_ros package as well, however without type masquerading it's quite challenging, so it's on hold from my side as of now.

@SteveMacenski
Copy link
Member

@mabelzhang you mentioned someone on your end was thinking about or in the middle of porting pcl_ros. Can you connect them with me so we can chat on the best path for this?

@mabelzhang
Copy link

mabelzhang commented Nov 2, 2019

@sloretz is working on porting pcl_ros. I believe there's some blending with the branch in this PR, the last I heard.

@SteveMacenski
Copy link
Member

SteveMacenski commented Nov 3, 2019

@sloretz you can find my email on my GitHub page (don't want to explicitly list it for the spam bots), we should chat on what you've done, doing, and in your queue so I can complement it and not have dual-work.

I'd love to have a componentized-pcl_ros done before end of 2019

@sloretz
Copy link
Contributor

sloretz commented Dec 5, 2019

@sloretz you can find my email on my GitHub page (don't want to explicitly list it for the spam bots), we should chat on what you've done, doing, and in your queue so I can complement it and not have dual-work.

Whoops, I missed this. I opened #255 for visibility. I'm working on the filters at the moment.

theseankelly added a commit to theseankelly/perception_pcl that referenced this pull request Aug 31, 2020
@130s
Copy link
Member

130s commented May 16, 2023

@klintan Is this PR still supposed to be merged? If not I suggest to close (as the title could falsely give impressions that ros2 port is not done even the basic part of it).

Looking at #255 (comment) and #225 (and maybe some others), basics seem to be completed.

@klintan
Copy link
Contributor Author

klintan commented May 18, 2023

@klintan Is this PR still supposed to be merged? If not I suggest to close (as the title could falsely give impressions that ros2 port is not done even the basic part of it).

Looking at #255 (comment) and #225 (and maybe some others), basics seem to be completed.

Agree, I'll close this one.

@klintan klintan closed this May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants