Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed naming of laser filter plugins in yaml files #70

Merged

Conversation

YoshuaNava
Copy link

This PR solves issue #69.

I just appended the prefix laser_filters/ to all the filter plugins call in this package yaml files.

@jonbinney
Copy link
Contributor

@YoshuaNava thanks for this fix. I'll also forward-port it to the kinetic-devel branch.

@jonbinney jonbinney merged commit a5ad2f0 into ros-perception:indigo-devel Jun 11, 2021
@RohanDwivedi
Copy link

RohanDwivedi commented Sep 20, 2021

Hi, @YoshuaNava I installed the melodic branch of map_laser package from the ros melodic repo sudo apt-get install ros-melodic-map-filter which depends on this filter, yet the issue doesn't seem to have been resolved over there yet! Can I understand how that can be done?
update: fixed it, my bad, the yaml file in the package was not following the convention

wg-perception/people#103

@jonbinney
Copy link
Contributor

@RohanDwivedi that's probably because this package hasn't been released on melodic since the fix was merged. So the source code in this repo has the fix, but the debian packages don't. Can you try cloning the indigo-devel version of this repo to your catkin workspace, recompiling, and see if that fixes the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants