Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaserScanRangeFilter not working. #87

Open
kjitender469 opened this issue Nov 29, 2019 · 2 comments
Open

LaserScanRangeFilter not working. #87

kjitender469 opened this issue Nov 29, 2019 · 2 comments

Comments

@kjitender469
Copy link

My launch file is:

My rplidar_range_filter_config.yaml is :

scan_filter_chain:

  • name: range_filter
    type: laser_filters/LaserScanRangeFilter
    params:
    use_message_range_limits: false
    lower_threshold: 0.5
    upper_threshold: 1.0
    lower_replacement_value: -.inf
    upper_replacement_value: .inf
@JohnTGZ
Copy link

JohnTGZ commented Jan 29, 2022

Hi there, could you highlight the problems you are facing and provide some data?

@fantalukas
Copy link

I was facing the same issue (LaserScanRangeFilter was not working). But I managed to fix this issue (problem was in the naming of the node). I will describe my scenario and a solution here. Maybe it could help you as well.

Expected behavior:
Ranges of scan data are filtered as requested in YAML file.

Current behavior:
Ranges of scan data are not filtered.

Scenario:
I used example case of range filter (current commit: cf27b36 launch file: https://github.com/ros-perception/laser_filters/blob/ros2/examples/range_filter_example.launch.py, yaml file: https://github.com/ros-perception/laser_filters/blob/ros2/examples/range_filter_example.yaml) and slightly modify that example.

More specifically, I slightly modified only launch file range_filter_example.launch.py as follows (the only change is adding name of node compare to example):

image

Comparing my and example versions:
MY modified version of example is NOT working. More specifically, update and configure methods are not called in LaserScanRangeFilter class (tested by logging). So the ranges of scan data are not filtered.
EXAMPLE version is working. Ranges of scan data are filtered as requested in yaml file.

Solution:
The only difference is that I added the name of the node to the launch file (name parameter).
After removing the name of node. It is working.

So the problem is in naming of the node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants