Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable chronically failing Noetic packages on ARM #224

Merged
merged 2 commits into from
Jul 18, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions noetic/release-arm64-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,17 @@ notifications:
- [email protected]
maintainers: true
package_blacklist:
- fetch_drivers
- ros_ign_gazebo
- fetch_drivers
- libntcan
- mocap_nokov
- nao_meshes
- pepper_meshes
- picovoice_driver
- prosilica_gige_sdk
- ros_ign_gazebo
- ros_speech_recognition
- rosrt
- skyway

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the indentation change here done in response to yamllint feedback or just convention?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to match the indentation of the other file so I could yank added lines from one buffer to the other for packages that were failing on both platforms.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One convention I really like from the ROS 2 build farm config is that build failures are annotated with a comment linking to the upstream issue reporting the failure: https://github.com/ros2/ros_buildfarm_config/blob/ros2/rolling/release-rhel-build.yaml#L19

If you have filed such issues it would be fantastic to adopt the same convention here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added upstream issue links in 4c0aed8

sync:
package_count: 1205
repositories:
Expand Down
15 changes: 14 additions & 1 deletion noetic/release-armhf-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,24 @@ notifications:
- [email protected]
maintainers: true
package_blacklist:
- exotica_pinocchio_dynamics_solver
- fetch_drivers
- gazebo_ros
- julius
- libntcan
- mapviz
- mecanum_gazebo_plugin
- mocap_nokov
- mongodb_store
- nao_meshes
- octovis
- pepper_meshes
- picovoice_driver
- ros_ign_gazebo
- gazebo_ros
- ros_speech_recognition
- rtabmap
- qt_advanced_docking
- spinnaker_camera_driver
package_ignore_list:
- libpointmatcher # Doesn't support 32-bit platforms. Optional for rtabmap
sync:
Expand Down