-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable chronically failing Noetic packages on ARM #224
Conversation
Upstream issues: * ipa320/cob_extern#112 * ipab-slmc/exotica#754 * ros-drivers/flir_camera_driver#108 * jsk-ros-pkg/jsk_3rdparty#467 * jsk-ros-pkg/jsk_3rdparty#468 * swri-robotics/mapviz#777 * NOKOV-MOCAP/mocap_nokov#2 * strands-project/mongodb_store#283 * ros-naoqi/nao_meshes#8 * ros-naoqi/pepper_meshes#9 * reinzor/picovoice_ros#6 * ros-drivers/prosilica_gige_sdk#6 * ridgeback/ridgeback_simulator#13 * ros/ros_realtime#15 * introlab/rtabmap#1037 * ntt-t3/skyway_for_ros#1 Signed-off-by: Shane Loretz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments. One of which I think will improve the maintainability and clarity around the blocked package builds so I'm requesting that as a change. If it's infeasible, then that won't block eventual approval.
noetic/release-arm64-build.yaml
Outdated
- ros_ign_gazebo | ||
- ros_speech_recognition | ||
- rosrt | ||
- skyway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the indentation change here done in response to yamllint feedback or just convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to match the indentation of the other file so I could yank added lines from one buffer to the other for packages that were failing on both platforms.
noetic/release-arm64-build.yaml
Outdated
- ros_ign_gazebo | ||
- ros_speech_recognition | ||
- rosrt | ||
- skyway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One convention I really like from the ROS 2 build farm config is that build failures are annotated with a comment linking to the upstream issue reporting the failure: https://github.com/ros2/ros_buildfarm_config/blob/ros2/rolling/release-rhel-build.yaml#L19
If you have filed such issues it would be fantastic to adopt the same convention here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added upstream issue links in 4c0aed8
Signed-off-by: Shane Loretz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating.
Upstream issues: