Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable chronically failing Noetic packages on ARM #224

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

sloretz
Copy link

@sloretz sloretz commented Jul 18, 2023

@sloretz sloretz self-assigned this Jul 18, 2023
@nuclearsandwich nuclearsandwich self-requested a review July 18, 2023 19:03
Copy link

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments. One of which I think will improve the maintainability and clarity around the blocked package builds so I'm requesting that as a change. If it's infeasible, then that won't block eventual approval.

- ros_ign_gazebo
- ros_speech_recognition
- rosrt
- skyway

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the indentation change here done in response to yamllint feedback or just convention?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to match the indentation of the other file so I could yank added lines from one buffer to the other for packages that were failing on both platforms.

- ros_ign_gazebo
- ros_speech_recognition
- rosrt
- skyway

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One convention I really like from the ROS 2 build farm config is that build failures are annotated with a comment linking to the upstream issue reporting the failure: https://github.com/ros2/ros_buildfarm_config/blob/ros2/rolling/release-rhel-build.yaml#L19

If you have filed such issues it would be fantastic to adopt the same convention here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added upstream issue links in 4c0aed8

@sloretz sloretz requested a review from nuclearsandwich July 18, 2023 23:39
Copy link

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating.

@sloretz sloretz merged commit 7f830cf into production Jul 18, 2023
@sloretz sloretz deleted the sloretz__noetic_audit_may_2023 branch July 18, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants