refactor(jtc): improve jtc tolerances#2133
refactor(jtc): improve jtc tolerances#2133thedevmystic wants to merge 7 commits intoros-controls:masterfrom
Conversation
This commit addresses the following:
- Seperate declaration from definition for better compilation
speed and readability.
- Add new function (create_error_trajectory_point).
- Add extensive doxygen-style comments.
- Add tests for new function (create_error_trajectory_point).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2133 +/- ##
==========================================
+ Coverage 84.80% 84.90% +0.10%
==========================================
Files 151 152 +1
Lines 14836 14890 +54
Branches 1286 1296 +10
==========================================
+ Hits 12581 12642 +61
+ Misses 1784 1779 -5
+ Partials 471 469 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Just dropping a comment since it's been 2 weeks with no follow ups :) |
P.S.Initially I didn't knew While we have But if we have to remove it then say it to me :) |
|
@christophfroehlich, sorry to tag you. But it's been almost 4 weeks without any follow-up. Thank you, and willing to make changes to suit the project! |
Hello respected maintainers and reviewers!
This is Surya!
This PR addresses the following:
If you have question, why I moved (or seperated) it to tolerances.cpp it is because the file was getting way too long for no reason. It would both increase compile time and future maintainance.
If you have question, why I added
create_error_trajectory_pointit is because we can calculate the current error point and then compare it with tolerances with ease!A note: This is a continuation of the previous PR #2048 (closed now). Instead of doing new features (new tolerances option) and refactoring in one PR. I split them into 2 PRs one doing refactoring (current) and another future PR adding feature.