Deprecate publish_dynamic_joint_states parameter in joint_state_broadcaster#2107
Merged
christophfroehlich merged 11 commits intomasterfrom Mar 17, 2026
Merged
Deprecate publish_dynamic_joint_states parameter in joint_state_broadcaster#2107christophfroehlich merged 11 commits intomasterfrom
christophfroehlich merged 11 commits intomasterfrom
Conversation
…caster - Change default value from true to false - Add deprecation warning in on_configure when parameter is set to true - Remove dynamic joint state assertions from tests
github-actions
Bot
requested review from
MarqRazz,
aprotyas,
fmauch,
mhubii and
saikishor
bmagyar
force-pushed
the
deprecate-dyn-joint-states
branch
from
f74877c to
abf2c5d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2107 +/- ##
==========================================
- Coverage 84.90% 84.60% -0.31%
==========================================
Files 153 153
Lines 15050 14958 -92
Branches 1300 1297 -3
==========================================
- Hits 12778 12655 -123
- Misses 1797 1828 +31
Partials 475 475
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
requested changes
Jan 15, 2026
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Fine for me, except..
bmagyar
commented
Jan 22, 2026
christophfroehlich
approved these changes
Jan 22, 2026
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Perfect, thanks :)
christophfroehlich
requested changes
Jan 22, 2026
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
oh no:
/home/runner/work/ros2_controllers/ros2_controllers/doc/ros2_controllers/doc/migration.rst:13: WARNING: undefined label: 'gpio_command_controller_userdoc'
bmagyar
commented
Jan 22, 2026
christophfroehlich
previously approved these changes
Jan 22, 2026
MarqRazz
previously approved these changes
Jan 22, 2026
saikishor
previously approved these changes
Jan 22, 2026
Contributor
|
This pull request is in conflict. Could you fix it @bmagyar? |
bmagyar
dismissed stale reviews from christophfroehlich, saikishor, and MarqRazz
via
820a796
github-actions
Bot
requested review from
Maverobot,
christophfroehlich,
destogl and
homalozoa
christophfroehlich
previously approved these changes
Mar 16, 2026
saikishor
previously approved these changes
Mar 16, 2026
christophfroehlich
dismissed stale reviews from saikishor and themself
via
989fd3c
christophfroehlich
approved these changes
Mar 17, 2026
saikishor
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step of #2044
Only meant for rolling, not to be backported.