Use global cmake macros and fix gcc-10 build

[christophfroehlich]

The change is motivated from the fact that we added a compiler option, which was introduced with gcc-11. But, debian11 (the humble tier 3), has only gcc-10 per default. (We don't have CI jobs for compatibility of the rolling version on humble debian/rhel.)

#24 258.0 --- stderr: joint_state_broadcaster
#24 258.0 cc1plus: error: '-Werror=range-loop-construct': no option '-Wrange-loop-construct'

So I added a switch depending on the gcc version to add this option or not. To make the options simpler to handle in the future, I propose to add a global cmake macro instead.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (28845e6) to head (968d128).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1527      +/-   ##
==========================================
- Coverage   84.26%   84.26%   -0.01%     
==========================================
  Files         123      123              
  Lines       11358    11361       +3     
  Branches      961      963       +2     
==========================================
+ Hits         9571     9573       +2     
+ Misses       1471     1470       -1     
- Partials      316      318       +2     

Flag	Coverage Δ
unittests	84.26% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

[mathias-luedtke]

@christophfroehlich: Careful, AFAIK bloom does not "bundle" files outside of the package folders.

[christophfroehlich]

oh, thanks for the hint. This means that the packages won't be built on the build farm right?

[mathias-luedtke]

oh, thanks for the hint. This means that the packages won't be built on the build farm right?

Yes.
Bloom creates tag like this:
https://github.com/ros2-gbp/ros2_controllers-release/tree/release/rolling/velocity_controllers/4.20.0-1

The common cmake would need to get packaged.
I am not sure, if it is worth the effort for a humble tier 3.

[christophfroehlich]

it's not the tier 3 I'm concerned about, I have a personal interest due to one of my projects at work ;) but could solve it differently, sure thing.
and the cmake file was just an idea in making the settings global, independent of the actual issue.