Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iron] Move deprecation warning message "class_type" into separate logger #1795

Open
firesurfer opened this issue Oct 15, 2024 · 1 comment
Labels

Comments

@firesurfer
Copy link
Contributor

Description

When we call ros2 service call /controller_manager/list_hardware_components controller_manager_msgs/srv/ListHardwareComponents in iron the controller manager prints 6 times:

[ros2_control_node-19] [WARN] [1728976987.424427528] [controller_manager]: The 'class_type' field in 'controller_manager_msgs/msg/HardwareComponentState.msg' is deprecated and will be removed soon. Please switch over client code to use 'plugin_name' instead.

As I have parts in the system that automatically call this service once in a while it really spams the log.

Action

Please move the warning in a sublogger: for example controller_manager.deprecation that can be silenced separately.

It should then be possible to silence the specific logger via command line / launch argument:

From the docs:

ros2 run logging_demo logging_demo_main --ros-args --log-level logger_usage_demo:=debug
@firesurfer firesurfer added the bug label Oct 15, 2024
@saikishor
Copy link
Member

@firesurfer feel free to open a PR with your suggestion and let the maintainers review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants