Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RealtimeBox broken API + realtime_box_best_effort.h proper deprecation #202

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

Fixes: #200

@christophfroehlich Thanks for nice summary of the issue.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.42%. Comparing base (5db607c) to head (6a0894f).

Files with missing lines Patch % Lines
include/realtime_tools/realtime_box.h 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   73.47%   73.42%   -0.05%     
==========================================
  Files           7        7              
  Lines         411      414       +3     
  Branches       67       68       +1     
==========================================
+ Hits          302      304       +2     
  Misses         68       68              
- Partials       41       42       +1     
Flag Coverage Δ
unittests 73.42% <66.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/realtime_tools/realtime_box.h 85.24% <66.66%> (-0.97%) ⬇️
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API of RealtimeBox is broken
2 participants