Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize the global context to avoid runtime_error upon destruction #128

Conversation

saikishor
Copy link
Member

This fixes the issue pointed by @christophfroehlich about the failing tests in the rolling that at the end of the tests upon destruction, the context becomes invalid

[ RUN ] RealtimeClock.get_system_time
 terminate called after throwing an instance of 'std::runtime_error'
 what(): context cannot be slept with because it's invalid

@saikishor saikishor force-pushed the fix_the_issue_with_global_context_on_destruction branch from 2303793 to e1a8720 Compare November 7, 2023 12:37
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@d90d85a). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #128   +/-   ##
=========================================
  Coverage          ?   45.97%           
=========================================
  Files             ?       12           
  Lines             ?      546           
  Branches          ?      285           
=========================================
  Hits              ?      251           
  Misses            ?       31           
  Partials          ?      264           
Flag Coverage Δ
unittests 45.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saikishor saikishor marked this pull request as draft November 7, 2023 12:47
This was referenced Nov 7, 2023
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple fix, thanks for digging into this!

@saikishor saikishor marked this pull request as ready for review November 7, 2023 13:19
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit 5e7c300 into ros-controls:master Nov 13, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants