root/treeformula/retobj make to cmake #773
Conversation
|
@phsft-bot build! |
guitargeek
force-pushed
the
treeformula_retobj_make_to_cmake
branch
2 times, most recently
from
e75d689 to
e05abf3
Compare
| gSystem->Load("libEvent"); | ||
| TFile *Event = TFile::Open("Event.new.split0.root"); | ||
| gSystem->Load("libTreeFormulaRetobjGeneration"); | ||
| TFile *Event = TFile::Open("Event.root"); |
There was a problem hiding this comment.
This is a very common file produced by roottest, it is much better to clarify which configuration of the file we are using.
There was a problem hiding this comment.
Hi @pcanal, thank you very much for the comment! What do you mean exactly by "to clarify which configuration of the file we are using"?
There was a problem hiding this comment.
See $ROOTSYS/test/MainEvent.cxx. For whatever reason this example use the configuration of the typical Event file with split level 0, and 'new' style branches, let's not lose that information (and not change the configuration of the generated file either)
| ROOT_LINKER_LIBRARY(TreeFormulaRetobjGeneration | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/TreeFormulaRetobjGeneration.cxx | ||
| G__TreeFormulaRetobjGeneration.cxx | ||
| LIBRARIES Core Tree Hist MathCore) |
There was a problem hiding this comment.
Please add the generation of the dictionary as required fixture.
guitargeek
force-pushed
the
treeformula_retobj_make_to_cmake
branch
from
e05abf3 to
71168de
Compare
|
Closed in favor of a corresponding PR in the main ROOT repository: |
ranslation made to CMake ; in relation with root-project/root#8913