[roottest] Migrate Make to CMake #18596
Conversation
There was a problem hiding this comment.
From root-project/roottest#726 (comment):
Please remove this only as the very last step. It is still used(/useable) to clean all the by-product of the 'make' runs that are executed by ctest.
| ROOT_LINKER_LIBRARY(TreeFormulaRetobjGeneration | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/TreeFormulaRetobjGeneration.cxx | ||
| G__TreeFormulaRetobjGeneration.cxx | ||
| LIBRARIES Core Tree Hist MathCore) |
There was a problem hiding this comment.
From root-project/roottest#773 (comment):
Please add the generation of the dictionary as required fixture.
| gSystem->Load("libEvent"); | ||
| TFile *Event = TFile::Open("Event.new.split0.root"); | ||
| gSystem->Load("libTreeFormulaRetobjGeneration"); | ||
| TFile *Event = TFile::Open("Event.root"); |
There was a problem hiding this comment.
It would be better to avoid this generic file name.
See the discussion in the original PR:
root-project/roottest#773 (comment)
| if(MSVC) | ||
| add_custom_command(TARGET IoCompressionGeneration POST_BUILD | ||
| COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_BINARY_DIR}/$<CONFIG>/libIoCompressionGeneration.dll | ||
| ${CMAKE_CURRENT_BINARY_DIR}/libIoCompressionGeneration.dll | ||
| COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_BINARY_DIR}/$<CONFIG>/libIoCompressionGeneration.lib | ||
| ${CMAKE_CURRENT_BINARY_DIR}/libIoCompressionGeneration.lib) | ||
| endif() |
There was a problem hiding this comment.
From root-project/roottest#774 (comment):
@bellenot Is that an okay solution?
There was a problem hiding this comment.
From root-project/roottest#774 (comment):
@bellenot Is that an okay solution?
Almost. It should be:
if(MSVC AND NOT CMAKE_GENERATOR MATCHES Ninja)
| ROOT_LINKER_LIBRARY(IoCompressionGeneration | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/IoCompressionGeneration.cxx | ||
| G__IoCompressionGeneration.cxx | ||
| LIBRARIES Core Tree Hist MathCore Physics Graf Matrix) |
There was a problem hiding this comment.
From root-project/roottest#774 (comment):
I recommend adding the ROOT_GENERATE_DICTIONARY as a FIXTURES_REQUIRED
| ROOTTEST_GENERATE_EXECUTABLE(IoCompressionGenerator | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/IoCompressionGenerator.cxx | ||
| LIBRARIES Core RIO Net Tree Hist MathCore IoCompressionGeneration | ||
| DEPENDS IoCompressionGeneration |
There was a problem hiding this comment.
From root-project/roottest#774 (comment):
This actually needs to be a FIXTURES_REQUIRED rather than a DEPENDS.
There was a problem hiding this comment.
We should also consider this previous discussion on root/io/perf:
Test Results 18 files 18 suites 3d 21h 7m 56s ⏱️ For more details on these failures, see this check. Results for commit dc78623. |
|
As another general reminder, one challenge in the migration from the |
This PR combines the following roottest PRs and re-applies to commits to the main repository, since
roottestwas merged into the main repo: