Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boresight Calibration End to End Testing #185

Merged
merged 39 commits into from
Sep 23, 2024
Merged

Boresight Calibration End to End Testing #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
1ef7f86
updates to measure_offset, compute_platescale_and_northangle (self co…
manduhmia Aug 29, 2024
873ae10
add tunable params for plate scale and north angle in mock data
manduhmia Aug 29, 2024
eb1fb1b
Merge branch 'main' of https://github.com/roman-corgi/corgidrp into a…
manduhmia Aug 29, 2024
5f4f850
Merge branch 'astrom_e2e' of https://github.com/roman-corgi/corgidrp …
manduhmia Sep 3, 2024
c3ac963
updating guess_template() to guess boresight cal and adding boresight…
manduhmia Sep 4, 2024
e2dbf2c
adding boresight cal to recipe
manduhmia Sep 4, 2024
1f9d76c
creating astrometry end to end test
manduhmia Sep 4, 2024
38ee546
adding optional argument to include gaussian noise to simulated image
manduhmia Sep 5, 2024
6c9996f
adding code to update sim data headers
manduhmia Sep 5, 2024
40097f9
altering boresight_cal function to take in multiple image frames, cha…
manduhmia Sep 6, 2024
4e2de8d
fixing AstrometricCalibration data object docstrings
manduhmia Sep 6, 2024
7673e5c
altering assert statements to check the single astrometric calibratio…
manduhmia Sep 6, 2024
3ebe78b
changing tolerance windows for unit testing
manduhmia Sep 6, 2024
60db43c
removing python path used for local test run
manduhmia Sep 6, 2024
f367b18
fixing assert statement tolerance for platescale
manduhmia Sep 6, 2024
1e71378
changes to use copy of image in source finder, altering match_sources…
manduhmia Sep 11, 2024
98fc130
creating new location for JWST calibration field data and adding it t…
manduhmia Sep 11, 2024
58daf03
updating comments to match new tolerance levels
manduhmia Sep 12, 2024
8c4fcac
adding keyword to combine data frames before boresight calibration
manduhmia Sep 20, 2024
4f8404f
updating new plate scale tolerance parameters in matching function
manduhmia Sep 20, 2024
123dcd9
adding parameter to determine how much of the central image to use in…
manduhmia Sep 20, 2024
c2124a3
updating the way star combinations are made to compute plate scale an…
manduhmia Sep 20, 2024
34a1ab1
updating default param values and making all function args visibile i…
manduhmia Sep 20, 2024
42ca507
adding a way to combine data frames before running the boresight cali…
manduhmia Sep 20, 2024
3d17c2e
fixing AstromCal data object headers and removing the need to import …
manduhmia Sep 20, 2024
d9db33c
updating documentation and default params for angle calculator and so…
manduhmia Sep 20, 2024
a79ee35
updating the way noise rms is used to create the simulated images and…
manduhmia Sep 20, 2024
3dd8980
updating number data frames to combine for e2e testing
manduhmia Sep 20, 2024
0243444
using a more efficient sorting method
manduhmia Sep 20, 2024
3ebee7c
fixing error in unit [mas] consistency when calculating sky separatio…
manduhmia Sep 20, 2024
3974e37
updating default value for center_radius param in plate scale and nor…
manduhmia Sep 20, 2024
eda9d99
fixing error of not using gaussian fit locations when computing north…
manduhmia Sep 20, 2024
9688633
updating default value for center_radius param in boresight calibrati…
manduhmia Sep 20, 2024
998ce20
updating number of noise data files to use and simulated data to crea…
manduhmia Sep 20, 2024
8e43205
Merge branch 'main' into astrom_e2e
manduhmia Sep 23, 2024
cf2861d
forgotten comma after boresight_calibration
manduhmia Sep 23, 2024
d884e50
changing header OBSTYPE from AST to ASTROM for relevant astrometric c…
manduhmia Sep 23, 2024
cff7105
changing threshold of sources to find/match for unit test
manduhmia Sep 23, 2024
60b9371
adding pytest mark to e2e test
manduhmia Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ include tests/test_data/metadata.yaml
include tests/test_data/metadata_eng.yaml
include tests/test_data/nonlin_sample.csv
include tests/test_data/nonlin_sample.fits
include corgidrp/data/JWST_CALFIELD2020.csv
237 changes: 138 additions & 99 deletions corgidrp/astrom.py
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion corgidrp/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,7 +1307,7 @@ class AstrometricCalibration(Image):
Class for astrometric calibration file.

Args:
data_or_filepath (str or np.array); either the filepath to the FITS file to read in OR the 2D image data
data_or_filepath (str or np.array); either the filepath to the FITS file to read in OR the 1D array of calibration measurements
pri_hdr (astropy.io.fits.Header): the primary header (required only if raw 2D data is passed in)
ext_hdr (astropy.io.fits.Header): the image extension header (required only if raw 2D data is passed in)

Expand Down
Loading
Loading