Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boresight Calibration End to End Testing #185

Merged
merged 39 commits into from
Sep 23, 2024
Merged

Boresight Calibration End to End Testing #185

merged 39 commits into from
Sep 23, 2024

Conversation

manduhmia
Copy link
Contributor

Describe your changes

Creating recipe template for boresight calibration end-to-end testing.

Type of change

  • New feature (non-breaking change which adds functionality)

Reference any relevant issues (don't forget the #)

Issue #153

Checklist before requesting a review

  • [ y] I have linted my code
  • [ y] I have verified that all unit tests pass in a clean environment and added new unit tests, as needed
  • [ y] I have verified that all docstrings are properly formatted and added new documentation, as needed

@manduhmia
updates to measure_offset, compute_platescale_and_northangle (self co…
1ef7f86 
…mparison), and field path change in boresight_cal
@manduhmia
add tunable params for plate scale and north angle in mock data
873ae10
@manduhmia
Merge branch 'main' of https://github.com/roman-corgi/corgidrp into a…
eb1fb1b 
…stro-cal
@manduhmia
Merge branch 'astrom_e2e' of https://github.com/roman-corgi/corgidrp …
5f4f850 
…into astrom_e2e
@manduhmia
updating guess_template() to guess boresight cal and adding boresight…
c3ac963 
… cal to steps
@manduhmia
adding boresight cal to recipe
e2dbf2c
@manduhmia
creating astrometry end to end test
1f9d76c
@manduhmia
adding optional argument to include gaussian noise to simulated image
38ee546
@manduhmia
adding code to update sim data headers
6c9996f
@manduhmia
altering boresight_cal function to take in multiple image frames, cha…
40097f9 
…nging helper function inputs from dataset to images
@manduhmia
fixing AstrometricCalibration data object docstrings
4e2de8d
@manduhmia
altering assert statements to check the single astrometric calibratio…
7673e5c 
…n file computed from all frames in input_dataset
@manduhmia
changing tolerance windows for unit testing
3ebe78b
@manduhmia
removing python path used for local test run
60db43c
@manduhmia
fixing assert statement tolerance for platescale
f367b18
@manduhmia
Copy link
Contributor Author

Currently the platescale calculation does not pass-- working on fixing this, but I wanted to create the PR

ajeldorado
ajeldorado reviewed Sep 9, 2024
View reviewed changes
tests/test_astrom.py Outdated Show resolved Hide resolved
@semaphoreP semaphoreP linked an issue Sep 9, 2024 that may be closed by this pull request
Create recipe template for boresight calibration #153
Closed
3 tasks
semaphoreP
semaphoreP reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@semaphoreP semaphoreP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and comments. Looking good! Hopefully we get the tests to pass!

corgidrp/astrom.py Outdated Show resolved Hide resolved
corgidrp/astrom.py Outdated Show resolved Hide resolved
corgidrp/recipe_templates/l1_to_boresight.json Show resolved Hide resolved
tests/e2e_tests/astrom_e2e.py Outdated Show resolved Hide resolved
tests/e2e_tests/astrom_e2e.py Outdated Show resolved Hide resolved
tests/e2e_tests/astrom_e2e.py Show resolved Hide resolved
@manduhmia
changes to use copy of image in source finder, altering match_sources…
1e71378 
… default params and adding plate scale tolerance param, updating sorting within function, updating the input dataset for each AstrometricCalibration data object
@manduhmia
creating new location for JWST calibration field data and adding it t…
98fc130 
…o the MANIFEST
@manduhmia
updating comments to match new tolerance levels
58daf03
@manduhmia
adding keyword to combine data frames before boresight calibration
8c4fcac
@manduhmia
updating new plate scale tolerance parameters in matching function
4f8404f
@manduhmia
adding parameter to determine how much of the central image to use in…
123dcd9 
… computing plate scale and north angle
@manduhmia
updating the way star combinations are made to compute plate scale an…
c2124a3 
…d using the mean of north angles instead of the median
@manduhmia
updating default param values and making all function args visibile i…
34a1ab1 
…n the boresight_calibration function
@manduhmia
adding a way to combine data frames before running the boresight cali…
42ca507 
…bration
@manduhmia
fixing AstromCal data object headers and removing the need to import …
3d17c2e 
…corgidrp.mocks
@manduhmia
updating documentation and default params for angle calculator and so…
d9db33c 
…urce finder functions
maxwellmb
maxwellmb approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@maxwellmb maxwellmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. I've run the e2e test on my machine and it passes. The only thing that came to my attention is that the OBSTYPE keyword used, "AST" isn't the one on the confluence header page: "ASTROM". I'm going to approve the PR, but make an issue about that.

corgidrp/walker.py Outdated Show resolved Hide resolved
@maxwellmb
Copy link
Contributor

Also, the conflicts need to be resolved.

@maxwellmb maxwellmb merged commit d43e942 into main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semaphoreP semaphoreP semaphoreP left review comments

@ajeldorado ajeldorado ajeldorado left review comments

@maxwellmb maxwellmb maxwellmb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create recipe template for boresight calibration
4 participants
@manduhmia @maxwellmb @semaphoreP @ajeldorado