Spec suite clean up #662
Merged
Spec suite clean up #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
force-pushed
the
spec-suite-clean-up
branch
5 times, most recently
from
86893e2 to
ad39b4c
Compare
solnic
force-pushed
the
spec-suite-clean-up
branch
2 times, most recently
from
eef4792 to
8093d99
Compare
solnic
force-pushed
the
spec-suite-clean-up
branch
5 times, most recently
from
50db9c3 to
8bd6123
Compare
solnic
force-pushed
the
spec-suite-clean-up
branch
from
8bd6123 to
15f6f99
Compare
- Isolate spec:compat group that describes deprecated behavior - Merge spec/suite/legacy/unit and spec/suite/legacy/integration specs into spec/suite/rom - Update remaining places that still relied on rom/compat - Mark view-related specs as pending - this feature will be rebuild as a component which will simplify implementation and make it more powerful - Disable flaky specs for now - unfortunately there's still some state leakage between various specs which make them fail sometimes, this will be fixed in separate PRs or directly in master
solnic
force-pushed
the
spec-suite-clean-up
branch
from
15f6f99 to
301cf79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean up that is meant to clearly separate specs that use rom 6.0 APIs without backward compatibility patches applied and the ones that do have these patches.
The new spec suite dir structure is as follows:
spec/suite/rom- the new spec suite, it includes a ton of tests from the original spec suite + more covering new functionality. Notice that this is no longer split into unit/integrationspec/suite/compat- specs covering APIs that will be deprecated and removed eventually (in rom 7.0). This includes a lot of original specs and it depends onrequire "rom/compat"TODO
spec/suite/rom/*dir structure