Spec suite clean up

- Isolate spec:compat group that describes deprecated behavior
- Merge unit and integration specs into spec/suite/rom
- Update remaining places that still relied on rom/compat
- Mark view-related specs as pending - this feature will be rebuild as
  a component which will simplify implementation and make it more powerful
- Disable flaky specs for now - unfortunately there's still some state
  leakage between various specs which make them fail sometimes, this will
  be fixed in separate PRs or directly in master

Author: solnic

.env

@@ -1,2 +1 @@
-BASE_DB_URI=postgres@postgres/rom
-
+BASE_DB_URI=rom:password@postgres/rom

.github/workflows/ci.yml

@@ -32,7 +32,7 @@ jobs:
         # TODO: re-add both as a separate workflow because it's just too slow
         # - jruby
         # - truffleruby
-        group: [rom, compat, legacy]
+        group: [rom, compat]
         include:
         - ruby: '3.0'
           coverage: 'false'

Rakefile

@@ -9,16 +9,12 @@ RSpec::Core::RakeTask.new("spec:rom") do |t|
   t.pattern = ["spec/suite/rom/**/*_spec.rb"]
 end
 
-RSpec::Core::RakeTask.new("spec:legacy") do |t|
-  t.pattern = ["spec/suite/legacy/**/*_spec.rb"]
-end
-
 RSpec::Core::RakeTask.new("spec:compat") do |t|
   t.pattern = ["spec/suite/compat/**/*_spec.rb"]
 end
 
 desc "Run all spec examples from all groups"
-task spec: ["spec:rom", "spec:legacy", "spec:compat"]
+task spec: ["spec:rom", "spec:compat"]
 
 task default: :spec
 

lib/rom/commands/class_interface.rb

@@ -88,10 +88,14 @@ def create_class(type: self, meta: {}, rel_meta: {}, plugins: {}, **, &block)
         klass = Dry::Core::ClassBuilder.new(name: type.name, parent: type).call
 
         result = meta.fetch(:result, :one)
-        klass.result(rel_meta.fetch(:combine_type, result))
+        klass.config.result = rel_meta.fetch(:combine_type, result)
 
         meta.each do |name, value|
-          klass.public_send(name, value)
+          if klass.respond_to?(name)
+            klass.public_send(name, value)
+          else
+            klass.config[name] = value
+          end
         end
 
         plugins.each do |plugin, options|
@@ -123,6 +127,15 @@ def use(plugin, **options)
         ROM.plugins[:command].fetch(plugin, adapter).apply_to(self, **options)
       end
 
+      # Return configured adapter identifier
+      #
+      # @return [Symbol]
+      #
+      # @api public
+      def adapter
+        config.component.adapter
+      end
+
       # Set before-execute hooks
       #
       # @overload before(hook)

lib/rom/commands/delete.rb

@@ -10,7 +10,7 @@ module Commands
     #
     # @abstract
     class Delete < Command
-      restrictable true
+      config.restrictable = true
     end
   end
 end

lib/rom/commands/graph.rb

@@ -35,8 +35,8 @@ class Graph
       # Graph results are mappable through `combine` operation in mapper DSL
       #
       # @example
-      #   create_user = rom.commands[:users].create
-      #   create_task = rom.commands[:tasks].create
+      #   create_user = rom.commands[:users][:create]
+      #   create_task = rom.commands[:tasks][:create]
       #
       #   command = create_user
       #     .curry(name: 'Jane')

lib/rom/commands/update.rb

@@ -10,7 +10,7 @@ module Commands
     #
     # @abstract
     class Update < Command
-      restrictable true
+      config.restrictable = true
     end
   end
 end

lib/rom/compat.rb

@@ -4,8 +4,8 @@
 
 require "rom/core"
 require "rom/resolver"
+require "rom/runtime"
 require "rom/container"
-require "rom/configuration"
 require "rom/global"
 
 require_relative "compat/auto_registration"
@@ -23,8 +23,10 @@ module Global
     alias_method :container, :runtime
   end
 
+  Configuration = Runtime
+
   # @api public
-  class Configuration
+  class Runtime
     # @api public
     # @deprecated
     def inflector=(inflector)

lib/rom/compat/components/dsl/schema.rb

@@ -9,11 +9,15 @@ module ROM
   module Components
     module DSL
       # @private
+      #
+      # rubocop:disable Metrics/AbcSize
+      # rubocop:disable Metrics/CyclomaticComplexity
+      # rubocop:disable Metrics/PerceivedComplexity
       class Schema < Core
         mod = Module.new do
           # @api private
           def call
-            return super unless config.dsl_class
+            return super unless config.dsl_class || config.view
 
             configure
 
@@ -37,6 +41,13 @@ def call
             end
           end
 
+          # @api public
+          #
+          # @deprecated
+          def associations(&block)
+            backend.associations(&block)
+          end
+
           private
 
           # @api private
@@ -64,26 +75,24 @@ def backend
 
           # @api private
           def configure
-            if !config.view
-              if provider.config.component.type == :relation
-                provider.config.component.update(dataset: config.dataset) if config.dataset
-                provider.config.component.update(id: config.as) if config.as
-
-                if provider.config.component.id == :anonymous
-                  provider.config.component.update(id: config.id)
-                end
-
-                if config.id.nil?
-                  config.update(id: provider.config.component.id)
-                end
-
-                if config.relation.nil?
-                  config.update(relation: provider.config.component.id)
-                end
-
-                if config.adapter.nil?
-                  config.update(adapter: provider.config.component.adapter)
-                end
+            if !config.view && provider.config.component.type == :relation
+              provider.config.component.update(dataset: config.dataset) if config.dataset
+              provider.config.component.update(id: config.as) if config.as
+
+              if provider.config.component.id == :anonymous
+                provider.config.component.update(id: config.id)
+              end
+
+              if config.id.nil?
+                config.update(id: provider.config.component.id)
+              end
+
+              if config.relation.nil?
+                config.update(relation: provider.config.component.id)
+              end
+
+              if config.adapter.nil?
+                config.update(adapter: provider.config.component.adapter)
               end
             end
 
@@ -110,6 +119,9 @@ def inferrer
             config.inferrer.with(enabled: config.infer)
           end
         end
+        # rubocop:enable Metrics/AbcSize
+        # rubocop:enable Metrics/CyclomaticComplexity
+        # rubocop:enable Metrics/PerceivedComplexity
 
         prepend(mod)
       end

lib/rom/components/dsl/association.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "rom/schema/associations_dsl"
+require "rom/relation/name"
 
 require_relative "core"
 
@@ -31,7 +32,14 @@ def backend
 
         # @api private
         def source
-          config.source || config.id
+          if provider.config.component.key?(:id)
+            # TODO: decouple associations DSL from Relation::Name
+            ROM::Relation::Name[
+              provider.config.component.id, provider.config.component.dataset
+            ]
+          else
+            config.source
+          end
         end
       end
     end