Make it possible to display remission from a DepthMap using ImageView #24
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any opinions on this? Would it be preferable to implement a new independent viewer for that? That would make it easier to customize the view, e.g. also encode distances using the hue -- or scale the image according to the actual resolutions. |
|
I was kind-of hoping somebody else would kick in ... but anyways. I think it would be preferable to create a separate viewer, yes. Which could defniitely use the ImageViewer behind the scenes to do the actual display. Overloading existing viewers for unrelated topics creates monsters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
DepthMapoften contains remission information (usually reflectance of IR light) which can be of interest.