Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename geometry from matrix constructor overloads #120

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Conversation

auscompgeek
Copy link
Member

See #119 for context.

Declaring numpy as a dependency is a no-go, but also we want to avoid importing numpy where possible. When using OpenBLAS (as we do for the roboRIO) importing numpy will initialise OpenBLAS, and OpenBLAS will allocate memory regions, which adds memory pressure.

Also, disable the keepalive inference for the various geometry constructors. These references aren't held after the constructor returns.

Depends on:

- build-system.requires: robotpy-build<2025.0.0b1,~=2025.0.0a8
Copy link
Member

@virtuald virtuald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@virtuald virtuald merged commit 1d6c7ee into main Dec 31, 2024
28 checks passed
@virtuald virtuald deleted the geom-from-matrix branch December 31, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants