wpimath: Add numpy dependency #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, I guess this has always been an issue for Rotation3d. My team never noticed because we've always had numpy in our dependency closure. |
|
Closing in favour of #120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wpilibsuite/allwpilib#7430 added, among others, a
Rotation2dconstructor overload that takes anEigen::Matrix2d. This now means calling theRotation2dconstructor requires numpy to be installed for the pybind11 Eigen caster to work.This breakage was noticed downstream in robotpy/robotpy-commands-v2#79 (comment)