Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated key signature #67

Merged
merged 2 commits into from
May 16, 2024
Merged

Updated key signature #67

merged 2 commits into from
May 16, 2024

Conversation

ahankinson
Copy link
Contributor

Replaces #54

Fixes #15
Fixes #16
Fixes #17
Fixes #26
Refs #35
Fixes #36

Copy link

github-actions bot commented May 15, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-16 17:04 UTC

Copy link
Contributor

@lpugin lpugin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am suggesting to use note codes instead of note names. But only as a suggestion.

v2/index.html Show resolved Hide resolved
v2/index.html Show resolved Hide resolved
v2/index.html Show resolved Hide resolved
v2/index.html Show resolved Hide resolved
v2/index.html Show resolved Hide resolved
v2/index.html Show resolved Hide resolved
@ahankinson
Copy link
Contributor Author

Since we would also need to change it in the actual "Note Names" section, outside of the scope of this change, I have opened #74 for this.

@lpugin lpugin force-pushed the fixed-key-signature-description branch from 0019831 to 1e1a485 Compare May 16, 2024 17:04
@lpugin lpugin merged commit 94f1488 into main May 16, 2024
1 check passed
@lpugin lpugin deleted the fixed-key-signature-description branch May 16, 2024 17:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants