Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternate charts panning #5635

Closed
wants to merge 60 commits into from
Closed

Alternate charts panning #5635

wants to merge 60 commits into from
+914 −74

Commits on Aug 23, 2024

  1. allow clicking and dragging

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3dfc1dc View commit details
    Browse the repository at this point in the history

  2. tweak brush opacity, comments

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    4df21b4 View commit details
    Browse the repository at this point in the history

  3. resolve interval data, access brush signal listener

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    979cf21 View commit details
    Browse the repository at this point in the history

  4. bind interval data to scrub range

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    4dc8ad9 View commit details
    Browse the repository at this point in the history

  5. clean up

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d18472b View commit details
    Browse the repository at this point in the history

  6. support brush on other alt charts

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9337346 View commit details
    Browse the repository at this point in the history

  7. brush color change

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8863b49 View commit details
    Browse the repository at this point in the history

  8. wip

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    bdd9ab6 View commit details
    Browse the repository at this point in the history

  9. workaround for clearing brush interval on esc

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    bbe63e5 View commit details
    Browse the repository at this point in the history

  10. debounce chart brush

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    a1882bf View commit details
    Browse the repository at this point in the history

  11. lint

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    14c260f View commit details
    Browse the repository at this point in the history

  12. check for not cmd/ctrl+z when zooming in on scrub

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    89215be View commit details
    Browse the repository at this point in the history

  13. build simple bar multi layer, support full height hover

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c1bfa9a View commit details
    Browse the repository at this point in the history

  14. remove axis title and reorient axis in multi layer simple bar

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e0cb62b View commit details
    Browse the repository at this point in the history

  15. wip

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    66a0070 View commit details
    Browse the repository at this point in the history

  16. temp fix of chart type selector

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8fb0cc4 View commit details
    Browse the repository at this point in the history

  17. first pass in vega renderer for vega signals support

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7447103 View commit details
    Browse the repository at this point in the history

  18. improve brush param checks before compiling vega lite to vega

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3ecc2f9 View commit details
    Browse the repository at this point in the history

  19. rename for clarity, fix brush end

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    52e59f2 View commit details
    Browse the repository at this point in the history

  20. ha! vega signals like pointerupdown vs. mouseupdown

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    018ee62 View commit details
    Browse the repository at this point in the history

  21. update brush for brushend signal, update issScrubbing

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c8fc9fd View commit details
    Browse the repository at this point in the history

  22. fix multi layer bar y axis formatting

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6f3579e View commit details
    Browse the repository at this point in the history

  23. reinstate tooltip for vega

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    1dc2f15 View commit details
    Browse the repository at this point in the history

  24. temp fix for band width in multi layer vega lite

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    817f7b4 View commit details
    Browse the repository at this point in the history

  25. fix undefined in isSignalEqual, clean up

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2811730 View commit details
    Browse the repository at this point in the history

  26. use band size and scale to tweak relative bar width

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6fe82f1 View commit details
    Browse the repository at this point in the history

  27. clean up

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3b7b830 View commit details
    Browse the repository at this point in the history

  28. highlight bars in interval selection

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    20458c5 View commit details
    Browse the repository at this point in the history

  29. remove global mark tooltip from vega config

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    0f3d970 View commit details
    Browse the repository at this point in the history

  30. prettier

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    47ab1aa View commit details
    Browse the repository at this point in the history

  31. adaptive scrub range to display range on every brush event

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    0fed1d0 View commit details
    Browse the repository at this point in the history

  32. lint, explored conditional tooltip with arr values in vega

    @lovincyrus
    lovincyrus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8cac8ac View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. add brush to other stacked charts

    @lovincyrus
    lovincyrus committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    ef0e7ef View commit details
    Browse the repository at this point in the history

  2. finalize esc to clear interval, move logic to vega signal manager

    @lovincyrus
    lovincyrus committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    78e620d View commit details
    Browse the repository at this point in the history

  3. lint

    @lovincyrus
    lovincyrus committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    1c19f25 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. revert to single layer for simple bar usage

    @lovincyrus
    lovincyrus committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ff33362 View commit details
    Browse the repository at this point in the history

  2. update simple bar styles

    @lovincyrus
    lovincyrus committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    6d897d1 View commit details
    Browse the repository at this point in the history

  3. fix brush clear isScrubbing

    @lovincyrus
    lovincyrus committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    064d252 View commit details
    Browse the repository at this point in the history

  4. update isScrubbing directly instead of passing through signal listeners

    @lovincyrus
    lovincyrus committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    47bce99 View commit details
    Browse the repository at this point in the history

  5. fix updateVegaOnTableHover

    @lovincyrus
    lovincyrus committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ba29b78 View commit details
    Browse the repository at this point in the history

  6. fix single layer simple bar brush on/off color

    @lovincyrus
    lovincyrus committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0d348f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. fix racy conditions, clean up

    @lovincyrus
    lovincyrus committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    667d948 View commit details
    Browse the repository at this point in the history

  2. clear scrub range when chart type changes, lint

    @lovincyrus
    lovincyrus committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8f52d9a View commit details
    Browse the repository at this point in the history

  3. fix clear interval when switching chart type

    @lovincyrus
    lovincyrus committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    38c124c View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. configure other chart types brush color, lint

    @lovincyrus
    lovincyrus committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    6c96239 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. fix brush opacity, address pr

    @lovincyrus
    lovincyrus committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b4e1666 View commit details
    Browse the repository at this point in the history

  2. clean up code for resetting scrub when changing chart type

    @lovincyrus
    lovincyrus committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c7c4599 View commit details
    Browse the repository at this point in the history

  3. remove previous racy prevention, in favor of runAsync

    @lovincyrus
    lovincyrus committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    109ab81 View commit details
    Browse the repository at this point in the history

  4. remove deadcode

    @lovincyrus
    lovincyrus committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    20ec4c2 View commit details
    Browse the repository at this point in the history

  5. lint

    @lovincyrus
    lovincyrus committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b9f081d View commit details
    Browse the repository at this point in the history

  6. clean up

    @lovincyrus
    lovincyrus committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ca7cdce View commit details
    Browse the repository at this point in the history

  7. coerce customFormatTypes in compiled spec, fix warning

    @lovincyrus
    lovincyrus committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9959209 View commit details
    Browse the repository at this point in the history

  8. clean up

    @lovincyrus
    lovincyrus committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7d46e48 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. initial panning

    @lovincyrus
    lovincyrus committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    216d95a View commit details
    Browse the repository at this point in the history

  2. hoist to pan left and right icon, wip panning

    @lovincyrus
    lovincyrus committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    169fcc7 View commit details
    Browse the repository at this point in the history

  3. wire up updatePanRange

    @lovincyrus
    lovincyrus committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    47c79e0 View commit details
    Browse the repository at this point in the history

  4. position pan icons

    @lovincyrus
    lovincyrus committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d37888a View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. vertical align pan icons

    @lovincyrus
    lovincyrus committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2dfc67d View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. wip

    @lovincyrus
    lovincyrus committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3cb2f24 View commit details
    Browse the repository at this point in the history

  2. wip

    @lovincyrus
    lovincyrus committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d100c4c View commit details
    Browse the repository at this point in the history