Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternate charts panning #5635

Closed
wants to merge 60 commits into from
Closed

Alternate charts panning #5635

wants to merge 60 commits into from

Conversation

lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented Sep 6, 2024 •
edited
Loading

Closes #4858

  • Fix positions of pan icons when vega chart layout shifts
  • Open this PR against main

@lovincyrus
allow clicking and dragging
3dfc1dc
@lovincyrus
tweak brush opacity, comments
4df21b4
@lovincyrus
resolve interval data, access brush signal listener
979cf21
@lovincyrus
bind interval data to scrub range
4dc8ad9
@lovincyrus
clean up
d18472b
@lovincyrus
support brush on other alt charts
9337346
@lovincyrus
brush color change
8863b49
@lovincyrus
wip
bdd9ab6
@lovincyrus
workaround for clearing brush interval on esc
bbe63e5
@lovincyrus
debounce chart brush
a1882bf
@lovincyrus
lint
14c260f
@lovincyrus
check for not cmd/ctrl+z when zooming in on scrub
89215be
@lovincyrus
build simple bar multi layer, support full height hover
c1bfa9a
@lovincyrus
remove axis title and reorient axis in multi layer simple bar
e0cb62b
@lovincyrus
wip
66a0070
@lovincyrus
temp fix of chart type selector
8fb0cc4
@lovincyrus
first pass in vega renderer for vega signals support
7447103
@lovincyrus
improve brush param checks before compiling vega lite to vega
3ecc2f9
@lovincyrus
rename for clarity, fix brush end
52e59f2
@lovincyrus
ha! vega signals like pointerupdown vs. mouseupdown
018ee62
@lovincyrus
update brush for brushend signal, update issScrubbing
c8fc9fd
@lovincyrus
fix multi layer bar y axis formatting
6f3579e
@lovincyrus
reinstate tooltip for vega
1dc2f15
@lovincyrus
temp fix for band width in multi layer vega lite
817f7b4
@lovincyrus
fix undefined in isSignalEqual, clean up
2811730
@lovincyrus
use band size and scale to tweak relative bar width
6fe82f1
@lovincyrus
clean up
3b7b830
@lovincyrus
highlight bars in interval selection
20458c5
@lovincyrus
remove global mark tooltip from vega config
0f3d970
@lovincyrus
prettier
47ab1aa
@lovincyrus
lint
1c19f25
@lovincyrus
revert to single layer for simple bar usage
ff33362
@lovincyrus
update simple bar styles
6d897d1
@lovincyrus
fix brush clear isScrubbing
064d252
@lovincyrus
update isScrubbing directly instead of passing through signal listeners
47bce99
@lovincyrus
fix updateVegaOnTableHover
ba29b78
@lovincyrus
fix single layer simple bar brush on/off color
0d348f3
@lovincyrus
fix racy conditions, clean up
667d948
@lovincyrus
clear scrub range when chart type changes, lint
8f52d9a
@lovincyrus
fix clear interval when switching chart type
38c124c
@lovincyrus
configure other chart types brush color, lint
6c96239
@lovincyrus
fix brush opacity, address pr
b4e1666
@lovincyrus
clean up code for resetting scrub when changing chart type
c7c4599
@lovincyrus
remove previous racy prevention, in favor of runAsync
109ab81
@lovincyrus
remove deadcode
20ec4c2
@lovincyrus
lint
b9f081d
@lovincyrus
clean up
ca7cdce
@lovincyrus
coerce customFormatTypes in compiled spec, fix warning
9959209
@lovincyrus
clean up
7d46e48
@lovincyrus
initial panning
216d95a
@lovincyrus
hoist to pan left and right icon, wip panning
169fcc7
@lovincyrus
wire up updatePanRange
47c79e0
@lovincyrus
position pan icons
d37888a
@lovincyrus lovincyrus force-pushed the cyrus/alternate-charts-scrub-to-zoom branch from 781c8a3 to 409a47a Compare September 10, 2024 14:59
@lovincyrus lovincyrus force-pushed the cyrus/alternate-charts-scrub-to-zoom branch from ff3e7a7 to 335a38a Compare September 13, 2024 19:47
Base automatically changed from cyrus/alternate-charts-scrub-to-zoom to main September 16, 2024 23:56
@lovincyrus lovincyrus closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Panning for alternate charts
1 participant
@lovincyrus