Removed unnecessary docs and replaced id with getKey in ticket reference

rexlManu · Dec 13, 2020 · 4b4d4bd · 4b4d4bd
1 parent d8b5e78
commit 4b4d4bd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/Observers/TicketMessageObserver.php b/src/Observers/TicketMessageObserver.php
@@ -21,9 +21,11 @@ public function created(TicketMessage $ticketMessage)
         $ticketActivity->save();
 
         $ticket = $ticketMessage->ticket;
-        if ($ticketMessage->user_id != $ticket->user_id)
+
+        if ($ticketMessage->user_id != $ticket->user_id) {
             $ticket->update([ 'state' => 'ANSWERED' ]);
-
+        }
+
         event(new TicketMessageEvent($ticketMessage->ticket()->first(), $ticketMessage));
     }
 

diff --git a/src/Observers/TicketObserver.php b/src/Observers/TicketObserver.php
@@ -33,9 +33,7 @@ public function updated(Ticket $ticket)
             if ($ticket->state == 'ANSWERED') {
                 return;
             }
-            /**
-             * EDIT BY RENE, bin einfach krasser als Manu :O
-             */
+
             $ticketActivity = new TicketActivity([ 'type' => $ticket->state == 'OPEN' ? 'OPEN' : 'CLOSE' ]);
             $ticketActivity->ticket()->associate($ticket);
             $ticketActivity->targetable()->associate($ticket);

diff --git a/src/Traits/HasTicketReference.php b/src/Traits/HasTicketReference.php
@@ -10,7 +10,7 @@ trait HasTicketReference
     public function toReference() : string
     {
         $type = basename(get_class($this));
-        return "$type #$this->id";
+        return "$type #$this->getKey()";
     }
 
 }