Add orient parameter to slot() shape #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe60
suggested changes
Jan 4, 2022
There was a problem hiding this comment.
Changing the orientation of the cylinders only won't work.
Simple example:
slot(r=5, h=3, l=20, orient=ORIENT_X);
Resulting solid:
I think you will have to arrange the whole object using orient_and_align() as soon as
orient != undef or align != undef
fe60
suggested changes
Jan 8, 2022
| @@ -2121,12 +2121,13 @@ module interior_fillet(l=1.0, r=1.0, ang=90, overlap=0.01, orient=ORIENT_X, alig | |||
| module slot( | |||
| p1=undef, p2=undef, h=10, l=undef, | |||
| r=undef, r1=undef, r2=undef, | |||
| d=undef, d1=undef, d2=undef | |||
| d=undef, d1=undef, d2=undef, | |||
| orient=undef | |||
There was a problem hiding this comment.
Suggested change
| orient=undef | |
| align=V_CENTER, orient=ORIENT_Z |
| ) { | ||
| r1 = get_radius(r1=r1, r=r, d1=d1, d=d, dflt=5); | ||
| r2 = get_radius(r1=r2, r=r, d1=d2, d=d, dflt=5); | ||
| sides = quantup(segs(max(r1, r2)), 4); | ||
| hull() spread(p1=p1, p2=p2, l=l, n=2) cyl(l=h, r1=r1, r2=r2, center=true, $fn=sides); | ||
| hull() spread(p1=p1, p2=p2, l=l, n=2) cyl(l=h, r1=r1, r2=r2, center=true, $fn=sides, orient=orient); |
There was a problem hiding this comment.
Suggested change
| hull() spread(p1=p1, p2=p2, l=l, n=2) cyl(l=h, r1=r1, r2=r2, center=true, $fn=sides, orient=orient); | |
| if (align!=V_CENTER || orient!=ORIENT_Z) { | |
| orient_and_align(size=[l+2*r1, 2*r1, h], orient=orient, align=align, orig_orient=ORIENT_Z, orig_align=V_CENTER) | |
| solid(); | |
| } else { | |
| solid(); | |
| } | |
| module solid() | |
| { | |
| hull() spread(p1=p1, p2=p2, l=l, n=2) cyl(l=h, r1=r1, r2=r2, align=V_CENTER, orient=ORIENT_Z, $fn=sides); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
slot()documentation said there should beorientin there, but it was missing.