Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunkified image visualizers #7023

Merged
merged 8 commits into from
Aug 2, 2024
Merged

Chunkified image visualizers #7023

merged 8 commits into from
Aug 2, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jul 31, 2024 •
edited by github-actions bot
Loading

Chunkified visualizers for all image types.

First signs of old APIs going away.
In particular, re_space_view_spatial has dropped its dependency on the old re_query.

Image

image

ImageEncoded

image

DepthImage

image

SegmentationImage

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 📺 re_viewer affects re_viewer itself 🔍 re_query affects re_query itself 📉 performance Optimization, memory use, etc do-not-merge Do not merge this PR 🍏 primitives Relating to Rerun primitives include in changelog labels Jul 31, 2024
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_15_images branch from 2aa6627 to 56a0706 Compare July 31, 2024 11:26
@teh-cmc teh-cmc changed the base branch from cmc/chunkified_queries_14_remaining_shapes to cmc/chunkified_queries_bonus_lending_iterators July 31, 2024 11:26
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_15_images branch from 56a0706 to b5ef13f Compare July 31, 2024 13:14
@teh-cmc teh-cmc marked this pull request as ready for review July 31, 2024 13:22
@teh-cmc teh-cmc mentioned this pull request Jul 31, 2024
Merged
6 tasks
@Wumpf Wumpf self-requested a review August 1, 2024 10:06
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_bonus_lending_iterators branch from d8c2048 to d50051a Compare August 2, 2024 09:08
Base automatically changed from cmc/chunkified_queries_bonus_lending_iterators to main August 2, 2024 09:08
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_15_images branch from 7f2ff10 to 918a82b Compare August 2, 2024 09:53
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Aug 2, 2024
@teh-cmc teh-cmc merged commit 2713062 into main Aug 2, 2024
31 of 33 checks passed
@teh-cmc teh-cmc deleted the cmc/chunkified_queries_15_images branch August 2, 2024 09:59
teh-cmc added a commit that referenced this pull request Aug 2, 2024
@teh-cmc
Chunkified text-log view with multi-timeline display (#7027)
56add26 
Title.

This brings back the multi-timeline display feature, which had regressed
when we introduced the new `ChunkStore`.

- Fixes #6611 
- DNM: requires #7023


![image](https://github.com/user-attachments/assets/15a148b5-92d7-4548-b3e4-fc535f742915)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog 📉 performance Optimization, memory use, etc 🍏 primitives Relating to Rerun primitives 🔍 re_query affects re_query itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @Wumpf