Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunkified text-log view with multi-timeline display #7027

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Chunkified text-log view with multi-timeline display #7027

merged 3 commits into from
Aug 2, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jul 31, 2024 •
edited by github-actions bot
Loading

Title.

This brings back the multi-timeline display feature, which had regressed when we introduced the new ChunkStore.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 📺 re_viewer affects re_viewer itself 🔍 re_query affects re_query itself do-not-merge Do not merge this PR 🍏 primitives Relating to Rerun primitives include in changelog labels Jul 31, 2024
@teh-cmc teh-cmc linked an issue Jul 31, 2024 that may be closed by this pull request
Bring back multi-timelines in text-log view #6611
Closed
@teh-cmc teh-cmc mentioned this pull request Aug 1, 2024
Merged
6 tasks
@Wumpf Wumpf self-requested a review August 1, 2024 10:08
Wumpf
Wumpf approved these changes Aug 1, 2024
View reviewed changes
crates/store/re_chunk/src/iter.rs Show resolved Hide resolved
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_15_images branch from 7f2ff10 to 918a82b Compare August 2, 2024 09:53
Base automatically changed from cmc/chunkified_queries_15_images to main August 2, 2024 09:59
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_16_text_log branch from dd8f5b3 to 3137c4a Compare August 2, 2024 10:02
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Aug 2, 2024
@teh-cmc teh-cmc merged commit 56add26 into main Aug 2, 2024
18 of 20 checks passed
@teh-cmc teh-cmc deleted the cmc/chunkified_queries_16_text_log branch August 2, 2024 10:02
teh-cmc added a commit that referenced this pull request Aug 2, 2024
@teh-cmc
Chunkify everything left (#7032)
bf47c42 
Chunkify all the spread out little things that are left all over the
place.

- DNM: requires #7027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog 🍏 primitives Relating to Rerun primitives 🔍 re_query affects re_query itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bring back multi-timelines in text-log view
2 participants
@teh-cmc @Wumpf