Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for Platform "Gerrit" #18961

Merged
merged 117 commits into from
Dec 29, 2023
Merged
Show file tree
Hide file tree
Changes from 59 commits
Commits
Show all changes
117 commits
Select commit Hold shift + click to select a range
a937e0a
Support for Platform "Gerrit" - v3
NiasSt90 Jun 28, 2022
c11a647
Update docs/usage/configuration-options.md
NiasSt90 Nov 22, 2022
9a0ae2b
Update lib/config/options/index.ts
NiasSt90 Nov 22, 2022
765972c
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 22, 2022
fbc49f5
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 22, 2022
071bc70
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 22, 2022
7565a96
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 22, 2022
ef24faa
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 22, 2022
012b8ad
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 22, 2022
b7b9357
Update lib/config/options/index.ts
NiasSt90 Nov 24, 2022
011634c
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 24, 2022
4201ec4
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 24, 2022
028f886
Update lib/util/http/gerrit.ts
NiasSt90 Nov 24, 2022
99028da
Merge remote-tracking branch 'origin/main' into gerrit_v3
NiasSt90 Nov 24, 2022
fd0def1
merge main and remove the Gerrit "local" presets implementation
NiasSt90 Nov 24, 2022
b46811b
Merge remote-tracking branch 'origin/main' into gerrit_v3
NiasSt90 Feb 22, 2023
54db50f
Gerrit V4.0
NiasSt90 Feb 22, 2023
fc40094
Merge remote-tracking branch 'origin/main' into gerrit_v3
NiasSt90 Feb 22, 2023
cde5ffa
cleanup: remove some old TODOs and other unnecessary things
NiasSt90 Feb 22, 2023
dd5523a
refactor: move all scm-methods from platform to scm-module
NiasSt90 Feb 23, 2023
b575fbf
fix: getBranchStatusCheck and createPr
NiasSt90 Feb 23, 2023
64b7d2e
review fixes for the documentation
NiasSt90 Feb 24, 2023
aad465c
one more review fix for the documentation
NiasSt90 Feb 24, 2023
f88b4ea
Update lib/modules/platform/gerrit/index.md
NiasSt90 Feb 27, 2023
a75d5dc
Update lib/modules/platform/gerrit/index.md
NiasSt90 Mar 2, 2023
b677883
more review fixes
NiasSt90 Mar 3, 2023
7d48d13
more review fixes
NiasSt90 Mar 3, 2023
e1a8860
more review fixes
NiasSt90 Mar 3, 2023
5842a09
more review fixes
NiasSt90 Mar 3, 2023
a067e9a
review fixes: Gerrit types with Records and using regEx helper
NiasSt90 Mar 6, 2023
bebded9
Merge remote-tracking branch 'origin/main' into gerrit_v3
NiasSt90 Mar 14, 2023
c6e8a75
Merge branch 'main' into gerrit_v3
NiasSt90 Mar 17, 2023
d4e5f11
Merge remote-tracking branch 'origin/main' into gerrit_v3
NiasSt90 Apr 3, 2023
1fd564c
Merge branch 'main' into gerrit_v3
NiasSt90 Apr 5, 2023
a95cde3
review fixes: visibility, types and config checks
NiasSt90 Apr 11, 2023
a37124c
review fixes: use got 'parseJson' callback mechanism
NiasSt90 Apr 11, 2023
5a050b2
Merge remote-tracking branch 'origin/main' into gerrit_v3
NiasSt90 Apr 11, 2023
17f6e5c
review fixes: important behavior change to scm.isBranchConflicted and…
NiasSt90 Apr 12, 2023
75bafa4
review fixes: some changes to types (Date -> string) and convert to '…
NiasSt90 Apr 12, 2023
7bf9be1
Merge branch 'main' into gerrit_v3
NiasSt90 Apr 12, 2023
0e08a37
review fixes: logger, fingerprint, readOnlyIssueBody, getRawFile, get…
NiasSt90 Apr 12, 2023
54a44b6
review fixes: minimize the Gerrit REST-Response Typescript interfaces…
NiasSt90 Apr 13, 2023
4f41465
Merge remote-tracking branch 'origin/main' into gerrit_v3
NiasSt90 Apr 13, 2023
4500df2
review fixes: remove (now) optional platform function "getVulnerabili…
NiasSt90 Apr 13, 2023
4481a1a
Merge remote-tracking branch 'origin/main' into gerrit_v3
NiasSt90 Apr 20, 2023
bc4ddc7
some further review fixes
NiasSt90 Apr 20, 2023
33830db
change to the common "autoApprove" option
NiasSt90 Apr 20, 2023
5ee57fc
Merge branch 'main' into gerrit_v3
NiasSt90 Apr 20, 2023
23e3296
Merge branch 'main' into gerrit_v3
NiasSt90 Apr 24, 2023
9e0430e
Merge branch 'main' into gerrit_v3
NiasSt90 May 10, 2023
ceba75a
Update lib/modules/platform/gerrit/index.md
NiasSt90 May 15, 2023
ac6fe32
more suggested changes by reviewer
NiasSt90 May 15, 2023
e71fe9b
refactoring: move some methods into other modules
NiasSt90 May 15, 2023
ba9c154
refactoring: move "findOwnPr" (with searchFilter-logic) into client m…
NiasSt90 May 15, 2023
89b0427
Merge branch 'main' into gerrit_v3
NiasSt90 Jun 12, 2023
ccca52d
refactor(http): Rename `useCache` option to `memCache` (#22300)
NiasSt90 Jun 15, 2023
acdcd75
Merge branch 'main' into gerrit_v3
NiasSt90 Jun 15, 2023
6319945
Merge branch 'main' into gerrit_v3
NiasSt90 Jun 22, 2023
eb43a54
Merge branch 'main' into gerrit_v3
NiasSt90 Jul 7, 2023
0841e77
Merge branch 'main' into gerrit_v3
NiasSt90 Jul 17, 2023
3eff61d
avoid the default non-working git-diff from git.prepareCommit to dete…
NiasSt90 Jul 17, 2023
bcee75a
Merge branch 'main' into gerrit_v3
NiasSt90 Jul 17, 2023
6b3155c
Update lib/modules/platform/gerrit/index.md
NiasSt90 Jul 19, 2023
1af7b22
Update lib/modules/platform/gerrit/index.md
NiasSt90 Jul 19, 2023
ee6070b
Update lib/modules/platform/gerrit/index.md
NiasSt90 Jul 19, 2023
efffdc6
more review fixes to documentation and stabilityDays rename
NiasSt90 Jul 19, 2023
d846fcb
Update lib/modules/platform/gerrit/index.md
NiasSt90 Jul 21, 2023
a5002c8
Update lib/modules/platform/gerrit/index.md
NiasSt90 Jul 21, 2023
c9d44ba
Update lib/modules/platform/gerrit/index.md
NiasSt90 Jul 21, 2023
53c7b98
Update lib/modules/platform/gerrit/index.md
NiasSt90 Jul 21, 2023
2871ed1
more review fixes to documentation
NiasSt90 Jul 21, 2023
4c10087
Merge branch 'main' into gerrit_v3
NiasSt90 Jul 21, 2023
31f915b
Merge remote-tracking branch 'origin/main' into gerrit_v3
NiasSt90 Aug 7, 2023
b6ae993
merge conflicts fixed
NiasSt90 Aug 7, 2023
90c93b6
Merge remote-tracking branch 'origin/main' into gerrit_v3
NiasSt90 Aug 8, 2023
c98f3c2
fix: PlatformScm.mergeToLocal overridden for Gerrit
NiasSt90 Aug 8, 2023
557341b
removed the (useless) "minimumReleaseAge" label support for Gerrit
NiasSt90 Aug 8, 2023
1d26cf2
lint-fix
NiasSt90 Aug 8, 2023
a1b5557
test-coverage
NiasSt90 Aug 8, 2023
c9457ba
Merge remote-tracking branch 'origin/main' into gerrit_v3
NiasSt90 Aug 15, 2023
c5330be
fix: prHourlyLimit (branches limit) was not respected
NiasSt90 Aug 15, 2023
addada6
fix: test-errors in main?
NiasSt90 Aug 15, 2023
404005e
Merge remote-tracking branch 'origin/main' into gerrit_v3
NiasSt90 Aug 28, 2023
f431a14
more review fixes
NiasSt90 Aug 28, 2023
605eb59
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 14, 2023
691e4f5
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 14, 2023
ad1c38b
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 14, 2023
f5c1604
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 14, 2023
54e2b31
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 14, 2023
cdb151c
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 14, 2023
87fe202
Merge branch 'main' into gerrit_v3
NiasSt90 Nov 14, 2023
fec6f7b
Merge branch 'main' into gerrit_v3
NiasSt90 Nov 14, 2023
1a37b35
more review fixes and (mostly lint) fixes after merging origin/master
NiasSt90 Nov 14, 2023
0433a95
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 14, 2023
33e0ad5
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 14, 2023
f33ae72
Update lib/modules/platform/gerrit/index.md
NiasSt90 Nov 14, 2023
f46d155
more review fixes
NiasSt90 Nov 14, 2023
c5df524
Merge branch 'main' into gerrit_v3
NiasSt90 Nov 30, 2023
105ac8b
merge fixes
NiasSt90 Nov 30, 2023
e57d16d
Merge branch 'main' into gerrit_v3
NiasSt90 Dec 14, 2023
0c644a2
replace gerritLabelMapping with the new statusCheckNames feature
NiasSt90 Dec 15, 2023
5c1a830
Merge branch 'main' into gerrit_v3
NiasSt90 Dec 15, 2023
247aaca
Update lib/modules/platform/gerrit/client.ts
NiasSt90 Dec 15, 2023
ec330a0
Update lib/modules/platform/gerrit/index.md
NiasSt90 Dec 15, 2023
97f42cc
Update lib/modules/platform/gerrit/index.md
NiasSt90 Dec 15, 2023
3cec0cb
Update lib/modules/platform/gerrit/index.md
NiasSt90 Dec 15, 2023
c75c042
Update lib/modules/platform/gerrit/index.md
NiasSt90 Dec 15, 2023
7c0cc09
fix documentation
NiasSt90 Dec 15, 2023
f95e78d
Update lib/modules/platform/gerrit/index.md
NiasSt90 Dec 15, 2023
4eaef9d
Update lib/modules/platform/gerrit/index.md
NiasSt90 Dec 15, 2023
53dfcf9
Merge branch 'main' into gerrit_v3
NiasSt90 Dec 15, 2023
078b9e1
Merge branch 'main' into gerrit_v3
NiasSt90 Dec 15, 2023
954669e
add documentation
NiasSt90 Dec 18, 2023
a5a4021
Merge branch 'main' into gerrit_v3
NiasSt90 Dec 18, 2023
c129f62
Merge branch 'main' into gerrit_v3
NiasSt90 Dec 18, 2023
9514878
Merge branch 'main' into gerrit_v3
NiasSt90 Dec 18, 2023
da6778c
more review fixes
NiasSt90 Dec 19, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added docs/usage/assets/images/gerrit-http-password.png
NiasSt90 marked this conversation as resolved.
Show resolved Hide resolved
NiasSt90 marked this conversation as resolved.
Show resolved Hide resolved
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions docs/usage/configuration-options.md
Original file line number Diff line number Diff line change
Expand Up @@ -1070,6 +1070,19 @@ If you allow Renovate to run on "Selected" repositories, `forkProcessing` will b
Only the `onboardingConfigFileName` (which defaults to `renovate.json`) is supported for `forkProcessing`.
You can't use other filenames because Renovate only checks the default filename when using the Git-hosting platform's API.

## gerritLabelMapping
NiasSt90 marked this conversation as resolved.
Show resolved Hide resolved

The name of the Gerrit labels to use for the `StabilityDays` and `Merge-Confidence` status.

```json
{
"stabilityDaysLabel": "Renovate-Stability",
"mergeConfidenceLabel": "Renovate-Confidence"
}
```
NiasSt90 marked this conversation as resolved.
Show resolved Hide resolved

If one or both are unset, then these information will not be passed to the Gerrit changes.
NiasSt90 marked this conversation as resolved.
Show resolved Hide resolved
NiasSt90 marked this conversation as resolved.
Show resolved Hide resolved

## gitAuthor

You can customize the Git author that's used whenever Renovate creates a commit.
Expand Down
1 change: 1 addition & 0 deletions lib/config/global.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export class GlobalConfig {
'dryRun',
'exposeAllEnv',
'executionTimeout',
'gerritLabelMapping',
NiasSt90 marked this conversation as resolved.
Show resolved Hide resolved
'githubTokenWarn',
'localDir',
'migratePresets',
Expand Down
13 changes: 12 additions & 1 deletion lib/config/options/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,7 @@ const options: RenovateOptions[] = [
description: 'Set to `true` to automatically approve PRs.',
type: 'boolean',
default: false,
supportedPlatforms: ['azure'],
supportedPlatforms: ['azure', 'gerrit'],
},
// depType
{
Expand Down Expand Up @@ -2559,6 +2559,17 @@ const options: RenovateOptions[] = [
default: false,
supportedPlatforms: ['github'],
},
{
name: 'gerritLabelMapping',
description:
'The name of the Gerrit labels to use for the `StabilityDays` and `Merge-Confidence` (branch)status.',
NiasSt90 marked this conversation as resolved.
Show resolved Hide resolved
type: 'object',
default: {
stabilityDaysLabel: undefined,
NiasSt90 marked this conversation as resolved.
Show resolved Hide resolved
mergeConfidenceLabel: undefined,
},
supportedPlatforms: ['gerrit'],
},
NiasSt90 marked this conversation as resolved.
Show resolved Hide resolved
{
name: 'branchNameStrict',
description: `Whether to be strict about the use of special characters within the branch name.`,
Expand Down
1 change: 1 addition & 0 deletions lib/config/presets/local/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const resolvers = {
bitbucket: local,
'bitbucket-server': local,
codecommit: null,
gerrit: local,
gitea,
github,
gitlab,
Expand Down
4 changes: 4 additions & 0 deletions lib/config/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,10 @@ export interface RepoGlobalConfig {
dockerUser?: string;
dryRun?: DryRunConfig;
executionTimeout?: number;
gerritLabelMapping?: {
stabilityDaysLabel?: string;
NiasSt90 marked this conversation as resolved.
Show resolved Hide resolved
mergeConfidenceLabel?: string;
};
gitTimeout?: number;
exposeAllEnv?: boolean;
githubTokenWarn?: boolean;
Expand Down
1 change: 1 addition & 0 deletions lib/constants/platforms.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ export type PlatformId =
| 'codecommit'
| 'bitbucket'
| 'bitbucket-server'
| 'gerrit'
NiasSt90 marked this conversation as resolved.
Show resolved Hide resolved
| 'gitea'
| 'github'
| 'gitlab'
Expand Down
2 changes: 2 additions & 0 deletions lib/modules/platform/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import * as azure from './azure';
import * as bitbucket from './bitbucket';
import * as bitbucketServer from './bitbucket-server';
import * as codecommit from './codecommit';
import * as gerrit from './gerrit';
import * as gitea from './gitea';
import * as github from './github';
import * as gitlab from './gitlab';
Expand All @@ -16,6 +17,7 @@ api.set(azure.id, azure);
api.set(bitbucket.id, bitbucket);
api.set(bitbucketServer.id, bitbucketServer);
api.set(codecommit.id, codecommit);
api.set(gerrit.id, gerrit);
api.set(gitea.id, gitea);
api.set(github.id, github);
api.set(gitlab.id, gitlab);
Expand Down
Loading