-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for Platform "Gerrit" #18961
Conversation
- all major features are complete and seems to be working fine see lib/modules/platform/gerrit/index.md for documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start with some simple changes. The docs need more work after merging my suggestions.
Some sections need more explanations.
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the git changes definetly needs to be in seperate PR to be merged before
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
@NiasSt90 I found that the azure devops platform uses this regex to "massage" the markdown and remove what is not needed. Maybe we can do something similar for removing the rebase checkbox and replace it with "Prefix the commit message with renovate/lib/modules/platform/azure/index.ts Lines 741 to 750 in af3b203
|
I've seen this. To your other "rebase.." question/answer: if you can edit the commit-msg from the Gerrit-ui why you don't click on the rebase button to enforce a rebase? How your "rebaseWhen" configuration looks like during your Gerrit-Tests? |
okay, rebuilding the complete change from current baseBranch is the same what is actually done with See here for some details about the current default behavior, the comment was gone to the wrong conversation.
okay, the commit-msg (prTitle) was checked independent of the |
# Conflicts: # lib/config/presets/local/__snapshots__/index.spec.ts.snap # lib/config/presets/local/index.spec.ts # lib/config/presets/local/index.ts
Any update on this getting merged anytime soon? |
For testing purpose i've pushed the current status (based on #19065) to this branch. Improvements:
|
2.14 has been EOL for > 4 years, I hope that there aren't that many installations of 2.14 anymore. If you are having trouble upgrading I know that Luca and company over at GerritForge have helped a lot of Gerrit users upgrade to latest. |
@viceice please approve when ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the docs.
@NiasSt90 should be no need to merge from main unless there's a conflict now |
Head branch was pushed to by a user without write access
To add +1 datapoint, I tested it with my company gerrit setup (last 3.9.1 version) and can confirm that PR works well. |
🎉 This PR is included in version 37.112.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What happened to the docs? https://docs.renovatebot.com/modules/platform/gerrit/ is empty? |
I am not familiar with renovate docs structure, but my guess file |
I've created a pull request for the fix: #26479 |
Co-authored-by: HonkingGoose <[email protected]> Co-authored-by: Michael Kriese <[email protected]> Co-authored-by: Rhys Arkins <[email protected]>
Co-authored-by: HonkingGoose <[email protected]> Co-authored-by: Michael Kriese <[email protected]> Co-authored-by: Rhys Arkins <[email protected]>
Co-authored-by: HonkingGoose <[email protected]> Co-authored-by: Michael Kriese <[email protected]> Co-authored-by: Rhys Arkins <[email protected]>
Changes
Allow to use Renovate on the Gerrit-Platform.
The Pull-Request-Branch Model of Renovate is translated to Gerrit pre-Submit Model (push to refs/for/).
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: