removed read bloat

[garethahealy]

as part of the below, I am doing a general review/removing bloat.

• Look at who has ADMIN #1000

this PR removes adding read to teams/people, since everyone in the org has read. so its not applying anything, just adding more bloat to the config file.

@pabrahamsson @sabre1041 as you two are probably the most peribolos knowledgable, you see anything wrong with this?

[sabre1041]

@garethahealy Since these are public repositories, by default, anyone (authenticated or not) will be able to read the content. From a technical perspective, removing these repositories from the teams will not impact their day to day activities. However, what will be lost is the scope/domain for which these teams operate. Is that something that we would like to remove?

Given that we will remove configurations that will be applied, we will gain a substantial boost in the speed the configurations are applied (a very good thing as it takes a considerable amount of time currently)

[garethahealy]

@garethahealy Since these are public repositories, by default, anyone (authenticated or not) will be able to read the content.

Agreed.

From a technical perspective, removing these repositories from the teams will not impact their day to day activities. However, what will be lost is the scope/domain for which these teams operate. Is that something that we would like to remove?

Yes, it does, but the below outweighs that concern. Can we label repos against teams? will do a Google to see if this is supported

Given that we will remove configurations that will be applied, we will gain a substantial boost in the speed the configurations are applied (a very good thing as it takes a considerable amount of time currently)

This is one of the main drivers for removing. It takes 1hr40mins to update the org each night and is only ever growing due to adding more repos.

[garethahealy]

From a technical perspective, removing these repositories from the teams will not impact their day to day activities. However, what will be lost is the scope/domain for which these teams operate. Is that something that we would like to remove?

Thinking about this a bit more. No, we don't lose context, as the blocks that give read are 99% copied into the sub-team, and define write or admin permissions, so are duplicates.

i.e.:

read which is removed in this PR:
https://github.com/redhat-cop/org/blob/main/config.yaml#L1446-L1449

same repos, but with write in the specific team:
https://github.com/redhat-cop/org/blob/main/config.yaml#L1461-L1464

so the context of "this team owns these repos" isn't lost, as we give them WRITE a few lines below.

[djdanielsson]

LGTM