Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentative to merge the edge related teams #1017

Merged
merged 5 commits into from
Mar 10, 2025

Conversation

ericzolf
Copy link
Contributor

This is my tentative to address issue #1009 but I'm not sure if I'm doing the right thing and I have many questions. I did my best to keep the old structures and maintainers/members, but:

  1. how does the automation react to renaming teams?
  2. is it necessary to have 3 levels of teams (mimicking the previous structures), couldn't we get rid of the read level? Doesn't anyway anybody have read level on any repo?
  3. does adding the repo edge.image_mode also triggers its creation?

@sabre1041 for your attention!

@ericzolf ericzolf requested a review from a team as a code owner February 24, 2025 14:00
@garethahealy
Copy link
Contributor

  1. delete old, create new - if you wanted to truly rename, its possible to use [1] but we've not done that before, and not sure we'd want me - would need a think
  2. some thought is happening on that now @ removed read bloat #1001 - but still WIP
  3. no, repos are manually created by the @redhat-cop-sre team - this config is just managing teams/permissions

[1] see previously @ example https://docs.prow.k8s.io/docs/components/cli-tools/peribolos/

@ericzolf
Copy link
Contributor Author

Can you take it from there and make it work? Or what do I need to do more?

@ericzolf
Copy link
Contributor Author

ericzolf commented Feb 25, 2025

Thinking about it, the easiest might be to:

  1. rename manually the teams:
    • rhel-bootc ⇒ edge-readers
    • rhel-bootc-mergers ⇒ edge-devels
    • rhel-edge-automation-arch ⇒ edge-admins
  2. create the repository edge.image_mode
  3. the rest should be done by applying the changes in this PR

@garethahealy garethahealy force-pushed the ericzolf-edge-merge-1009 branch from 24f16b6 to ae93278 Compare March 10, 2025 13:35
@garethahealy
Copy link
Contributor

chatted with @sabre1041 and agreed format

@garethahealy garethahealy merged commit 15ef28a into redhat-cop:main Mar 10, 2025
2 checks passed
@ericzolf ericzolf deleted the ericzolf-edge-merge-1009 branch March 14, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants