Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tekton pipelineref #374

Merged

Conversation

maysunfaisal
Copy link
Member

@maysunfaisal maysunfaisal commented Aug 2, 2023

What does this PR do?:

Updates the tekton pipelineref.

Making the same changes as konflux-ci/release-service#231

Which issue(s)/story(ies) does this PR fixes:

N/A

PR acceptance criteria:

  • Unit/Functional tests

  • Documentation

  • Client Impact

How to test changes / Special notes to the reviewer:

Pipeline run should pass

Signed-off-by: Maysun J Faisal <[email protected]>
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 82.96% and project coverage change: -0.55% ⚠️

Comparison is base (1afd7ae) 84.61% compared to head (20f0499) 84.07%.
Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   84.61%   84.07%   -0.55%     
==========================================
  Files          27       31       +4     
  Lines        3530     4226     +696     
==========================================
+ Hits         2987     3553     +566     
- Misses        402      508     +106     
- Partials      141      165      +24     
Files Changed Coverage Δ
pkg/devfile/errors.go 100.00% <ø> (ø)
controllers/component_controller.go 73.87% <62.31%> (-3.72%) ⬇️
cdq-analysis/pkg/devfile.go 68.30% <68.30%> (ø)
cdq-analysis/pkg/componentdetectionquery.go 69.28% <69.28%> (ø)
controllers/componentdetectionquery_controller.go 74.51% <71.42%> (+3.97%) ⬆️
controllers/component_controller_finalizer.go 73.46% <75.00%> (-1.54%) ⬇️
pkg/github/token_mock.go 75.67% <75.67%> (-24.33%) ⬇️
controllers/application_controller.go 78.46% <76.81%> (-3.07%) ⬇️
cdq-analysis/pkg/detect.go 73.38% <79.54%> (ø)
pkg/github/token.go 87.74% <84.95%> (-7.65%) ⬇️
... and 17 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maysunfaisal maysunfaisal changed the title Update tektok pipelineref Update tekton pipelineref Aug 2, 2023
Copy link
Collaborator

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsony, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [elsony,maysunfaisal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal maysunfaisal merged commit 95578da into redhat-appstudio:main Aug 2, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants