Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Grafana dashboard path #371

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

avi-biton
Copy link
Contributor

What does this PR do?:

Update Grafana dashboard path after change in infra-deployments

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 82.96% and project coverage change: -0.76% ⚠️

Comparison is base (1afd7ae) 84.61% compared to head (ce48460) 83.86%.
Report is 81 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   84.61%   83.86%   -0.76%     
==========================================
  Files          27       31       +4     
  Lines        3530     4226     +696     
==========================================
+ Hits         2987     3544     +557     
- Misses        402      515     +113     
- Partials      141      167      +26     
Files Changed Coverage Δ
pkg/devfile/errors.go 100.00% <ø> (ø)
controllers/component_controller.go 71.92% <59.42%> (-5.67%) ⬇️
cdq-analysis/pkg/devfile.go 68.30% <68.30%> (ø)
cdq-analysis/pkg/componentdetectionquery.go 69.28% <69.28%> (ø)
controllers/componentdetectionquery_controller.go 74.51% <71.42%> (+3.97%) ⬆️
controllers/component_controller_finalizer.go 67.34% <75.00%> (-7.66%) ⬇️
pkg/github/token_mock.go 75.67% <75.67%> (-24.33%) ⬇️
controllers/application_controller.go 80.00% <76.81%> (-1.53%) ⬇️
cdq-analysis/pkg/detect.go 73.38% <79.54%> (ø)
pkg/github/token.go 87.74% <84.95%> (-7.65%) ⬇️
... and 17 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avi-biton
Copy link
Contributor Author

@maysunfaisal @yangcao77 can you please review?

@maysunfaisal
Copy link
Member

FYI to PR readers: redhat-appstudio/infra-deployments#2169

@avi-biton
Copy link
Contributor Author

@kim-tsao Can you please review?

@maysunfaisal
Copy link
Member

@avi-biton can you pls rebase and push again? The new commit should fix the test failure we are seeing on Pact tests

@maysunfaisal
Copy link
Member

I also updated the pipelineref #374

Update Grafana dashboard path after change in `infra-deployments`

Signed-off-by: Avi Biton <[email protected]>
@avi-biton
Copy link
Contributor Author

Rebased

@openshift-ci openshift-ci bot added the lgtm label Aug 3, 2023
@maysunfaisal maysunfaisal merged commit ccbca3c into redhat-appstudio:main Aug 3, 2023
5 of 7 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avi-biton, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants