Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove down to PHP 7.0 set, as not practically complete and useful #152

Merged
merged 3 commits into from
Aug 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions config/set/downgrade-php71.php

This file was deleted.

11 changes: 0 additions & 11 deletions config/set/level/down-to-php70.php

This file was deleted.

9 changes: 4 additions & 5 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ parameters:

paths:
- src
- config
- rules
- tests
- rules-tests
Expand Down Expand Up @@ -38,9 +39,6 @@ parameters:

- '#Calling PHPStan\\Reflection\\Native\\NativeFunctionReflection\:\:getName\(\) is not covered by backward compatibility promise\. The method might change in a minor PHPStan version#'

# bool as status return
- '#Method "refactorParamType\(\)" returns bool type, so the name should start with is/has/was#'

-
message: '#New objects with "\$functionLikeReflection" name are overridden\. This can lead to unwanted bugs, please pick a different name to avoid it#'
path: rules/DowngradePhp80/NodeAnalyzer/UnnamedArgumentResolver.php
Expand Down Expand Up @@ -68,8 +66,6 @@ parameters:

- '#Parameter \#3 \$stmt of method Rector\\DowngradePhp72\\Rector\\FuncCall\\DowngradePregUnmatchedAsNullConstantRector\:\:processReplace\(\) expects PhpParser\\Node\\Stmt, PhpParser\\Node given#'

- '#but class PhpParser\\Node\\Stmt\\Expression is not generic#'

- '#(.*?)\:\:refactor\(\) should return array<PhpParser\\Node\\Stmt>\|PhpParser\\Node\\Stmt\\ClassConst\|null but returns array<PhpParser\\Node\\Stmt>\|PhpParser\\Node\\Stmt\|null#'

-
Expand All @@ -87,3 +83,6 @@ parameters:
# phpstan need to load rector nodes first to avoid this
- '#Rector\\Core\\Contract\\PhpParser\\Node\\StmtsAwareInterface#'

-
message: '#Parameter \#1 \$attributeClass of class Rector\\DowngradePhp80\\ValueObject\\DowngradeAttributeToAnnotation constructor expects class\-string, string given#'
path: "config/*"

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading