Remove down to PHP 7.0 set, as not practically complete and useful #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-downgrade-cleanup
branch
from
9281a7b
to
bd4d5cd
Compare
TomasVotruba
force-pushed
the
tv-downgrade-cleanup
branch
from
621a3a9
to
71375e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to https://github.com/rectorphp/rector-downgrade-php/pulls?q=Remove+down
Based on testing of previous set removals, the most used version to downgrade to is PHP 7.1 and 7.2.
Lot of tools target these versions to be available to wide range of PHP legacy projects.
This allows us to ship thinner Rector binary and focus on the rules that are commonly used - making Rector faster and easier to use in more projects 👏