-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[release] Hello world test for Azure #57597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
01f012e
4657c9c
7fa39d6
9f038cf
a258168
010f583
b1f10af
728be9d
6772985
087ed03
a2fe6a0
c30e864
8364933
e65538d
ba1b06c
f8f6d0b
a0cf6bb
481249d
af82f30
184a5a5
5c65e4f
4002c21
2b98232
edc3f0d
e244057
034138c
8c134b9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,9 +69,10 @@ banned_words() { | |
./ci/lint/check-banned-words.sh | ||
} | ||
|
||
# Use system python to avoid conflicts with uv python in forge image | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this should say that we want to use the system python for python version 3.xx |
||
doc_readme() { | ||
pip install -c python/requirements_compiled.txt docutils | ||
cd python && python setup.py check --restructuredtext --strict --metadata | ||
/usr/bin/python -m pip install -c python/requirements_compiled.txt docutils | ||
cd python && /usr/bin/python setup.py check --restructuredtext --strict --metadata | ||
} | ||
|
||
dashboard_format() { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
cloud_id: {{env["ANYSCALE_CLOUD_ID"]}} | ||
region: us-west-2 | ||
|
||
head_node_type: | ||
name: head_node | ||
instance_type: 4CPU-16GB | ||
|
||
worker_node_types: [] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,7 @@ | |
from urllib.parse import urlparse | ||
from typing import Optional, List, Tuple | ||
|
||
AZURE_STORAGE_ACCOUNT = "rayreleasetests" | ||
OUTPUT_JSON_FILENAME = "output.json" | ||
AWS_CP_TIMEOUT = 300 | ||
TIMEOUT_RETURN_CODE = 124 # same as bash timeout | ||
|
@@ -69,6 +70,8 @@ def run_storage_cp(source: str, target: str): | |
return False | ||
|
||
storage_service = urlparse(target).scheme | ||
if target.startswith(f"https://{AZURE_STORAGE_ACCOUNT}.dfs.core.windows.net"): | ||
storage_service = "azure_blob" | ||
cp_cmd_args = [] | ||
if storage_service == "s3": | ||
cp_cmd_args = [ | ||
|
@@ -88,7 +91,7 @@ def run_storage_cp(source: str, target: str): | |
source, | ||
target, | ||
] | ||
elif storage_service == "abfss": | ||
elif storage_service == "azure_blob": | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Azure Blob Storage URL Scheme IssueThe update to the storage service detection logic removes support for |
||
subprocess.run(["azcopy", "login", "--identity"], check=True) | ||
cp_cmd_args = [ | ||
"azcopy", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
ANYSCALE_HOST=https://console.anyscale-staging.com | ||
RELEASE_AWS_ANYSCALE_SECRET_ARN="arn:aws:secretsmanager:us-west-2:029272617770:secret:release-automation/anyscale-staging-token20231008005227440600000001-JTgxb0" | ||
RELEASE_DEFAULT_CLOUD_ID="cld_5nnv7pt2jn2312x2e5v72z53n2" | ||
RELEASE_DEFAULT_PROJECT="prj_y8syktydl7ltabhz5axdelwnce" | ||
ANYSCALE_CLOUD_STORAGE_PROVIDER=abfss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hate to ask, but could you split this forge change into a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind.. I will merge this altogether this time.
next time please split this to another PR since it deserves its own step of change.