-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[release] Hello world test for Azure #57597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a 'hello world' test for Azure by adding the necessary configuration files and a new test variation. The overall structure is correct, but there is a critical security vulnerability due to hardcoded secrets in the release/ray_release/environments/azure.env
file. These sensitive values must be removed from the repository and managed through a secure secrets management system.
ANYSCALE_HOST=https://console.anyscale-staging.com | ||
RELEASE_AWS_ANYSCALE_SECRET_ARN="arn:aws:secretsmanager:us-west-2:029272617770:secret:release-automation/anyscale-staging-token20231008005227440600000001-JTgxb0" | ||
RELEASE_DEFAULT_CLOUD_ID="cld_5nnv7pt2jn2312x2e5v72z53n2" | ||
RELEASE_DEFAULT_PROJECT="prj_y8syktydl7ltabhz5axdelwnce" | ||
ANYSCALE_CLOUD_STORAGE_PROVIDER=abfss | ||
ANYSCALE_PROJECT_NAME="default" | ||
ANYSCALE_CLOUD_NAME="anyscale_aks_public_default_cloud_us_west_2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding secrets and sensitive identifiers in source code is a major security risk. This file contains sensitive values such as RELEASE_AWS_ANYSCALE_SECRET_ARN
, RELEASE_DEFAULT_CLOUD_ID
, and RELEASE_DEFAULT_PROJECT
. These values should be removed from the repository and managed through a secure mechanism, such as CI/CD environment variables or a secret management service like AWS Secrets Manager. The values can then be injected into the test environment at runtime.
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this working?
b18d057
to
5c65e4f
Compare
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
First test running on AKS cloud!