Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add image signing for dev images and add release sbom #1629

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

akashsinghal
Copy link
Collaborator

@akashsinghal akashsinghal commented Jul 11, 2024

Description

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1658

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@akashsinghal
Copy link
Collaborator Author

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@akashsinghal akashsinghal changed the title build: add image signing for dev images build: add image signing for dev images and release sbom Jul 18, 2024
@akashsinghal akashsinghal changed the title build: add image signing for dev images and release sbom build: add image signing for dev images and add release sbom Jul 18, 2024
@akashsinghal akashsinghal marked this pull request as ready for review July 18, 2024 21:44
susanshi
susanshi previously approved these changes Jul 22, 2024
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

binbin-li
binbin-li previously approved these changes Jul 22, 2024
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

junczhu
junczhu previously approved these changes Jul 22, 2024
Copy link
Collaborator

@junczhu junczhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akashsinghal akashsinghal dismissed stale reviews from junczhu, susanshi, and binbin-li via 725d6f5 July 24, 2024 19:06
@akashsinghal akashsinghal mentioned this pull request Jul 25, 2024
1 task
@susanshi
Copy link
Collaborator

to merge after #1641

@akashsinghal
Copy link
Collaborator Author

akashsinghal commented Jul 31, 2024

After this PR is merged, the following secrets and variables MUST be added to Ratify and each fork of Ratify that will run AKS and dev publishing workflows:

Secrets:

  • AZURE_SUBSCRIPTION_ID
  • AZURE_TENANT_ID
  • AZURE_CLIENT_ID
  • AZURE_KV_KEY_ID: The azure keyvault key URL

Variables:

  • AZURE_KV_PLUGIN_URL: This is the notation-azure plugin binary download URL
  • AZURE_KV_CHECKSUM: This is the checksum value of the plugin binary

Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@akashsinghal akashsinghal merged commit 17f829a into ratify-project:dev Jul 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate supply chain metadata for dev assets
4 participants