Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Ratify release assets #1437

Open
1 task
akashsinghal opened this issue May 2, 2024 · 3 comments
Open
1 task

Sign Ratify release assets #1437

akashsinghal opened this issue May 2, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@akashsinghal
Copy link
Collaborator

What would you like to be added?

Ratify should sign published GHCR images. Tools like cosign's keyless support can help here.

Anything else you would like to add?

No response

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@akashsinghal akashsinghal added enhancement New feature or request triage Needs investigation labels May 2, 2024
@susanshi susanshi added this to the v1.3.0 milestone May 10, 2024
@susanshi susanshi removed the triage Needs investigation label May 10, 2024
@akashsinghal
Copy link
Collaborator Author

Scope here can include publishing SBOM + SLSA provenance intoto attestations using buildx

@akashsinghal
Copy link
Collaborator Author

akashsinghal commented Jun 12, 2024

Here is the current proposal. I suggest we iterate on this as need arises:

  • Add signing for both release and dev images. (total of 6 unique images)
  • Integrate signing in both dev asset publishing and release publishing workflows
  • Generate cosign keyless signatures
  • Generate Notary project signatures via notation. This requires maintaining an azure key vault with the certs. The public cert will be published as ratify-verification.crt file in the root of the repo. For now, both release and dev images will be signed with same cert

@akashsinghal akashsinghal changed the title Sign Ratify release assets Sign Ratify dev assets Jul 25, 2024
@akashsinghal akashsinghal changed the title Sign Ratify dev assets Sign Ratify release assets Jul 25, 2024
@akashsinghal akashsinghal modified the milestones: v1.3.0, v1.4.0 Jul 25, 2024
@akashsinghal
Copy link
Collaborator Author

As per discussion in CC 7/24/24, we will open a separate issue to track dev image signing only. Dev image signing will begin as soon as #1629 is merged. We will gather feedback on verification process and then enable for release assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants