-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to OpenCV==4.10.0 #80
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Is the DockerHub updated too?
It's not ready yet due to failing unit tests related to handeye calibration
@rameau-fr with OpenCV=4.10.0 we have some unit tests failing. It's probably related to hand-eye calibration not running. The change to OpenCV was introduced in opencv/opencv#24897 where a part of the change was hard-coded filtering (with no possibility to change the thresholds). if (Pgij_norm < 0.3 || Pcij_norm < 0.3 || Pgij_norm > 1.7 || Pcij_norm > 1.7) {
continue;
} |
Are there any expected quality upgrades from this PR? |
@shreyas23 TSAI hand-eye calibration method seems to be improved in the latest OpenCV. However, after the upgrade, our unit tests, where the accuracy is checked against ground truth (synthetic sequences), are failing. Potentially, there is a bug in our code (#77, #56) and we will try to investigate it further when we have time. Meanwhile, if you know of bugs or improvements to the codebase, feel free to list them. PR contributions are also welcomed. |
Seems that backwards compatibility can be achieved by setting |
Unit tests still do not pass. Potentially, there is more divergence between OpenCV versions despite setting |
Closes #66